feat(ui): add light theme toggle#19
Merged
Merged
Conversation
Contributor
Author
Light theme cleanup updatePushed a follow-up pass that fixes the remaining light-theme mismatches from the screenshots:
Verification:
Updated private registry images:
Frontend image smoke: nginx served the SPA root and expected title. |
Contributor
Author
Search modal light-theme fixPushed a follow-up for the search popup: Verification:
Updated private registry images:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for maintainer review. This implementation was AI-assisted, then independently reviewed and verified with the project build and tests.
Summary
data-themeon the document root, keeping dark mode as the default.Verification
npm run buildnpm testnpx eslint src/components/theme/ThemeProvider.tsx src/components/theme/ThemeToggle.tsx src/components/theme/theme-context.ts src/components/nav/PageToolbar.tsxNote: full
npm run lintstill reports pre-existing lint errors elsewhere in the app; the files touched by this PR pass targeted ESLint.