Conversation
`track add` (used by the chapter add + track add workflow, as opposed to `entry add`) never wrote `overlayLabel` onto the track object. Confirmed via device testing that this is the actual cause of tracks playing fine in the Yoto app/iOS but failing on physical Yoto players (observed as the device skip-cycling through chapters without playing audio). This mirrors the parent chapter's overlayLabel, matching the pattern used by `entry add` and the documented upload flow at yoto.dev/myo/uploading-to-cards. Complements TheBestMoshe#2, which addresses format/channels but not this field. Fixes TheBestMoshe#1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
track add(used by the chapter add + track add workflow, as opposed toentry add) never wroteoverlayLabelonto the track object. Confirmed via device testing that this is the actual cause of tracks playing fine in the Yoto app/iOS but failing on physical Yoto players (observed as the device skip-cycling through chapters without playing audio).This mirrors the parent chapter's overlayLabel, matching the pattern used by
entry addand the documented upload flow at yoto.dev/myo/uploading-to-cards.Complements #2, which addresses format/channels but not this field. Fixes #1.