-
Notifications
You must be signed in to change notification settings - Fork 33
Add new linker args for web multi-threading
#728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct to me, and I installed it and can confirm that the multi-threading works on rustc 1.94.0-nightly (fa5eda19b 2025-12-12).
I don't have a self-contained project to share on hand, but if we'd like more testing I can set up a repo.
BD103
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks sound, but I have not tested it!
TimJentzsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test right now, but code looks sensible :)
| bevy run web --unstable multi-threading | ||
| ``` | ||
|
|
||
| ## What it Does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we have to always update these when the required flags change. I think it's fine to delete this section since you can always use the --verbose mode to see the actual flags set. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree that removing this section is probably the right call. While the information it contains is interesting, I don't think it's necessary in order to use web multi-threading.
While it is quite the fast turnaround, given we released v0.5.0 only five days ago (#724), the Bevy Jam #7 starts in 6 days. The jammers will want support for Bevy 0.18, so we are releasing with support for it! ## Useful Links - [Changelog](https://github.com/TheBevyFlock/bevy_cli/blob/release-linter-0.6.0/bevy_lint/CHANGELOG.md) - [Migration Guide](https://github.com/TheBevyFlock/bevy_cli/blob/release-linter-0.6.0/bevy_lint/MIGRATION.md) - [All Changes](lint-v0.5.0...main) - [Linter Release Process](https://thebevyflock.github.io/bevy_cli/contribute/linter/how-to/release.html) ## For Reviewers Please install the latest version of Bevy Lint and test it on all of your Bevy 0.18 projects! You can install it with the Bevy CLI: ```sh bevy lint install main ``` When testing, please make sure to enable lints that are disabled by default (`pedantic`, `restriction`, and `nursery` lints) [through `Cargo.toml`](https://thebevyflock.github.io/bevy_cli/linter/usage/toggling-lints-cargo-toml.html) or [through your code](https://thebevyflock.github.io/bevy_cli/linter/usage/toggling-lints-code.html). ## Next Steps Once this gets at least one approval by a Bevy Maintainer with no outstanding changes, this will be merged and kick off the `bevy_lint` v0.6.0 release! I'll then make a Github release and open up the post-release PR as well. After that, I would also like to release Bevy CLI v0.1.0-alpha.3 so that [this bug fix](#728) lands. After all that, I plan on making sure [`bevy_new_2d`](https://github.com/TheBevyFlock/bevy_new_2d) is updated to use the new versions.
I added the linker args as described here: #642 (comment)
Tested
I checked by running the default 2d template with wasm-bindgen 0.2.108 and
1.94.0-nightly. I sadly don't have another good testing project, would appreciate your feedback @CorvusPrudensCloses #642