Fix EntityPath for Python 3.14 by subclassing OS-specific pathlib classes#3
Open
Vanthys wants to merge 1 commit intoTheBiomics:devfrom
Open
Fix EntityPath for Python 3.14 by subclassing OS-specific pathlib classes#3Vanthys wants to merge 1 commit intoTheBiomics:devfrom
Vanthys wants to merge 1 commit intoTheBiomics:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 removed/refactored the private pathlib attribute
_flavour.EntityPathpreviously accessedPath('.')._flavour, which caused anAttributeError: 'PosixPath' object has no attribute '_flavour'This merge request removes the dependency on private pathlib internals and updates EntityPath to subclass the appropriate concrete path class (
PosixPathorWindowsPath) based on the current platform.Works on Python 3.14+ and is backwards compatible with Python 3.11-3.13. Also there is no change to public API or expected behavior of
EntityPath.