fix: the session reviewer's context budget was a ceiling nobody could raise - #172
Merged
Merged
Conversation
… raise When the review helpers were shared between the executors (#167), the session side got `DEFAULT_CONTEXT_BUDGET` hardcoded at the call site. The headless executor has taken that number from configuration since #150. So a 272 KB file was always "too large to include", and the reviewer rejected for lacking exactly the evidence the harness had refused it: "web/src/main.tsx is not included in full and I cannot inspect the surrounding markup/context around that block here." That is the right answer to a partial view, and #156 exists precisely because a reviewer denied its surroundings rejects for the shape of its own prompt. Giving it the file back is not weakening the gate — it is the gate's own stated requirement. `SessionExecutor` now takes `context_budget`, defaulting to the same number so nothing changes for anyone not passing it, and `run --context-budget` reaches both executors rather than only one. Worth separating from the case next to it: R3's reviewer *had* the file it needed and rejected for a guard against hypothetical future serialization that the item never asked for. That one is a calibration question and is recorded as #171, deliberately unfixed. This one was a defect I introduced. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the review helpers were shared between the executors (#167), the session
side got
DEFAULT_CONTEXT_BUDGEThardcoded at the call site. The headlessexecutor has taken that number from configuration since #150.
So a 272 KB file was always "too large to include", and the reviewer rejected
for lacking exactly the evidence the harness had refused it:
That is the correct answer to a partial view — #156 exists precisely because a
reviewer denied its surroundings rejects for the shape of its own prompt.
Giving it the file back is not weakening the gate; it is the gate's own stated
requirement.
SessionExecutornow takescontext_budget, defaulting to the same number sonothing changes for anyone not passing it, and
run --context-budgetreachesboth executors rather than only one.
Worth separating from the case next to it
Two items were rejected in the same run and they are not the same problem:
satisfy the narrow support-bundle requirement", and rejected anyway for a
guard against future accidental serialization that the item never asked for.
That is a calibration question, and I deliberately did not fix it by editing
the prompt a fifth time.
Conflating them would have made the second look solved.
All four gates green.
🤖 Generated with Claude Code