migration: switch internal deps to pinned GitHub git sources - #2
Merged
Conversation
Add 5 tests: handshake encode/decode, request serialization, keepalive, choke, and interested message deserialization.
The bencode crate cannot represent Option::None (no nil/null in bencode), so serializing a PeerExtendedMessageIds with any Option<u8> field set to None errored with "bencode doesn't support None". In practice this affected callers that hand-construct the struct — for tests, mock peers, or peers advertising a partial extension set (e.g. ut_metadata-only peers that don't implement ut_pex / ut_holepunch). The standard PeerExtendedMessageIds::my() path was unaffected because it sets all three Some. Add #[serde(skip_serializing_if = "Option::is_none")] to all three fields and a regression test covering the partial + fully-empty cases. Bumps version to 0.1.2 (additive, backwards-compatible — fully-Some structs serialize identically to before).
thedancingdeveloper
force-pushed
the
migration/github-native-source
branch
3 times, most recently
from
July 23, 2026 23:16
2d67906 to
379aba1
Compare
AusAgentSmith
approved these changes
Jul 23, 2026
AusAgentSmith
left a comment
AusAgentSmith
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: source content verified with cargo check/--all-targets before push; migration policy and rust CI both green.
thedancingdeveloper
force-pushed
the
migration/github-native-source
branch
from
July 23, 2026 23:22
379aba1 to
2b1986e
Compare
AusAgentSmith
approved these changes
Jul 23, 2026
AusAgentSmith
left a comment
AusAgentSmith
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: rebased onto current main, resolved conflicts (Forgejo-registry version bump kept, replaced with GitHub git sources; workflow delete/modify resolved), removed stale [patch] blocks, restored ci.yml that a bad conflict resolution had deleted. Migration policy and rust CI both green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto main, resolving conflicts against the historical Forgejo-registry commit (kept the version bump, replaced the Forgejo registry deps with pinned GitHub git sources) and a workflow-file delete/modify conflict (kept the delete). Also removes the now-redundant [patch] blocks pointing legacy AusAgentSmith-org git URLs at Forgejo, since dependencies now point directly at TheDancingDeveloper-org. Verified with a clean cargo check --all-targets. Part of the Forgejo registry deprecation sequence.