Reload player object when invalid pointer - #11
Merged
Merged
Conversation
Contributor
Author
|
Sorry if this needs to be on a new branch, ill change it if its an issue |
Owner
|
Thank you! I’m sick righ now, when i feel better I will check and merge |
Owner
|
All perfect! Thank you! |
Contributor
Author
|
No problem, thank you for merging! |
Owner
If you want I’m working in a in-minecraft render system. I will push it in a different branch for now because is work in progress |
Contributor
Author
To be honest im not all too good with this type of project but id be happy to try and learn more and maybe even contribute more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
playerfield in theMinecraftstruct with a.get_player()method.Which, when called, checks the current player pointer against the newest one and replaces it when unequal.
This fixes the issue where you have to reload the client every time a new world is joined