Repository navigation
Auto-build conjure.exe via CI instead of committing a static binary - #5
Merged
Merged
Conversation
The committed conjure.exe was already two bug fixes stale and caused real confusion: someone re-tested a fix by re-downloading the repo but kept launching the old frozen exe, which didn't have the fix and appeared to prove it hadn't worked. Adds a GitHub Actions workflow with two jobs: `test` runs the unittest suite on every push/PR; `build-windows` (gated on `test` passing, and only for actual pushes to main or a manual dispatch -- never PR branches) builds conjure.exe with PyInstaller on windows-latest and publishes it to a `latest-build` GitHub Release with make_latest so it's always reachable at /releases/latest. It can never go stale relative to main again. Removes the manually-committed conjure.exe and conjure_config.json (a per-user runtime file that leaked real local paths into git history) -- both are already gitignored going forward. README now points to the release page as the primary way to get a double-clickable build, keeping the manual PyInstaller steps for people building their own copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conjure.exewas a frozen snapshot from before the last two bug fixes (path validation, Stage 2 persistence). Re-pullingmainnever touches it, so double-clicking it kept running stale, unfixed code..github/workflows/build-windows-exe.ymlwith two jobs:test— runspython -m unittest tests.test_conjure tests.test_wizard -von every push and PR.build-windows— gated ontestpassing, runs only on an actual push tomain(or manualworkflow_dispatch), never on PR branches. Buildsconjure.exewith PyInstaller onwindows-latestand publishes it to alatest-buildGitHub Release withmake_latest: true, so it's always reachable at/releases/latestand can't drift frommainagain.conjure.exeandconjure_config.json(a per-user runtime file that had leaked real local file paths into git history) — both were already added to.gitignorein a previous PR.Test plan
python -m unittest tests.test_conjure tests.test_wizard -v— 48/48 passing locallyconjure.exeshows up on/releases/latestGenerated by Claude Code