Repository navigation
Give Conjure a real app icon - #6
Merged
Merged
Conversation
Adds assets/icon.ico (multi-resolution) and assets/icon.png -- a wand
and spark badge in purple/gold, matching the "Conjure" name. Wired in
two places:
- PyInstaller build (README's manual steps and the CI workflow) now
passes --icon=assets/icon.ico, so the built .exe carries it in
Explorer and the taskbar.
- conjure.py sets the window icon directly for a source run
(python conjure.py): iconbitmap with the .ico on Windows, iconphoto
with the .png elsewhere, both best-effort and silently skipped if
the assets folder or platform doesn't support it.
Verified headless (xvfb) that the source-run icon path doesn't raise
on Linux (takes the iconphoto fallback), and the full test suite still
passes (48/48) since this touches no core.py/wizard.py logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/icon.ico(multi-resolution: 16/24/32/48/64/128/256) andassets/icon.pngare generated with Pillow (script not committed, output is).--icon=assets/icon.ico, so the built.execarries it in Explorer/taskbar.conjure.pyalso sets the window icon directly for a source run (python conjure.py):iconbitmapwith the.icoon Windows,iconphotowith the.pngelsewhere — both best-effort, silently skipped if the assets folder or platform doesn't support it, so it can never crash the app.Test plan
python -m unittest tests.test_conjure tests.test_wizard -v— 48/48 passing (no core.py/wizard.py logic touched)xvfb-run) that the source-run icon-setting code doesn't raise on Linux, where it takes theiconphotofallback pathGenerated by Claude Code