Frontend fixes: interim Reports pane never rendered, elapsed timer frozen, Ollama URL field restore - #4
Open
cdwashi wants to merge 3 commits into
Open
Frontend fixes: interim Reports pane never rendered, elapsed timer frozen, Ollama URL field restore#4cdwashi wants to merge 3 commits into
cdwashi wants to merge 3 commits into
Conversation
…estore - Field template no longer hardcodes localhost; uses the server-provided provider URL (env-aware since d611295) - setIfPresent threw on text inputs (Array.from(undefined)), silently aborting the whole late-restore batch - now handles input vs select Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The v2 template redesign removed #report-preview-card but the legacy renderer still dereferenced it unconditionally in two places: - renderReportPreview() crashed before drawing any tab, so interim analyst reports never appeared during a run - the run-start reset crashed before clearing currentReportSections, leaking previous-run sections into the next run Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Legacy 'let startTime' is lexically scoped, but the v2 timer override reads window.startTime - always undefined, so the timer never ticked. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three v2-redesign regressions in
app.js:#report-preview-card, butrenderReportPreview()still dereferences it unconditionally — it throws before drawing any tab, every time. The run-start reset crashes on the same ID before clearingcurrentReportSections, so previous-run sections would also leak into the next run. Both now guarded.let startTimeis lexically scoped, but the v2 timer override readswindow.startTime— always undefined.window.startTimeis now published on run start.value="http://localhost:11434/v1"(now uses the server-provided, env-aware provider URL), and the saved-state restorer calledArray.from(el.options)— which throws on text inputs, silently aborting the whole restore batch. Restorer now handles input-vs-select.