Drawutil funcs#4
Open
owlyoop wants to merge 1 commit into
Open
Conversation
- changed func signatures from 4 shorts to 4 ints - added a HudRectDraw struct to drawutil.h since I couldn't find something matching in context.py, might be wrong - 100% match https://decomp.me/scratch/bNzDh https://decomp.me/scratch/spFFL
Contributor
|
Apologies for the delay! Thanks for sending this through! I think changing those shorts to ints was probably the right move, I think they almost universally used ints in the function signatures as opposed to shorts. The drawutil struct is probably fine, I'll double check when I've got a moment to review this PR fully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my first time trying this sort of thing & am interested in learning how to help, so sorry if I am wasting your time!
I have some 100% matches on decomp.me for the drawutil funcs:
func_8001FE48 https://decomp.me/scratch/bNzDh
func_8001FC90 https://decomp.me/scratch/spFFL
I think these two functions are for drawing the grey rects in the loading screen for loading/quitting a save.
I was only able to get a 100% match if I changed the function signatures of both functions from 4 shorts to 4 ints.
Also for func_8001FC90, I wasn't sure what D_8006C664 was since nothing was similar in the context file, so I created a struct in drawutil.h "HudRectDraw". Wasn't sure if this is correct to do or what the naming conventions are.