fix(security): minimize cached credentials, separate config from transport (v0.1.1) - #2
Merged
Merged
Conversation
…sport (v0.1.1) writeCache persists only apiKey/accountId/email; the OAuth access token stays in memory (nothing ever read it back). Credential-source resolution moves to network-free src/config.ts; auth.ts is transport-only with explicit args. Fixes the ClawHub suspicious.env_credential_access heuristic at its root and documents the credential story in README. Also fixes the login script dist import path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClawHub audit flagged suspicious.env_credential_access on the 0.1.0 artifact. Remediation: (1) writeCache persists only apiKey/accountId/email, OAuth token never touches disk (+test asserting absence); (2) env/cache-path resolution moved to network-free src/config.ts, auth.ts transport-only; (3) README Security section documents storage + network allowlist; (4) fixed login script dist import path. Verified locally: typecheck, build, 24 tests, smoke 5+5, clawhub validate PASS.