bugfix(system): Update crash message

[JohnsterID]

No description provided.

[xezon]

Has merge conflicts.

[greptile-apps]

Greptile Summary

This PR updates the crash dialog shown to players by replacing the stale EA-era message (referencing defunct EA forums) with a modern, informative one that shows the crash report file path, optional minidump directory, a stack-trace excerpt when debug symbols are available, and a link to the community crash-report GitHub repository. Both UnHandledExceptionFilter functions (Generals and Zero Hour) are also updated to call ReleaseCrash so that unhandled Win32 exceptions now surface the same dialog instead of silently exiting.

Key changes:

• extractCrashLocation helper added to pull the first 5 lines of g_LastErrorDump for display in the crash dialog.
• ReleaseCrash rebuilt with a structured message-building loop; ReleaseCrashLocalized appends the same paths to localized messages.
• g_LastErrorDump.clear() now called at startup (guarded by DEBUG_STACKTRACE) to prevent uninitialized data being shown in the dialog on early crashes.
• Both UnHandledExceptionFilter implementations now call ReleaseCrash("Unhandled exception") after the minidump is created, ensuring users always see the crash dialog.
• Three new comment headers reference the date 06/01/2025, which is prior to the current year and should be updated (rule violation, also applies at lines 866 and 935 in Debug.cpp).
• Two MessageBox/MessageBoxW calls changed from nullptr to NULL for the HWND parameter, conflicting with the project's nullptr-only style rule.

Confidence Score: 4/5

• Safe to merge after addressing the minor style issues; the core logic is correct and well-guarded.
• The functional changes are straightforward and beneficial — users now get actionable crash information. The only issues found are style-level: three comment dates referencing 2025 instead of 2026, and two MessageBox calls using NULL instead of nullptr. No logic errors or data-integrity concerns were identified.
• Core/GameEngine/Source/Common/System/Debug.cpp — comment dates and nullptr/NULL inconsistencies.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/Common/System/Debug.cpp	Core crash dialog logic rewritten — adds crash-path info, GitHub link, and stack-trace location excerpt. Three new comment headers are dated 2025 (violating the current-year rule) and two MessageBox calls switched from nullptr to NULL.
Generals/Code/Main/WinMain.cpp	Adds a ReleaseCrash("Unhandled exception") call in UnHandledExceptionFilter so users see the new crash dialog for all unhandled exceptions, not just explicit DEBUG_CRASH calls.
GeneralsMD/Code/Main/WinMain.cpp	Identical change to Generals/Code/Main/WinMain.cpp, applied to the Zero Hour variant of the exception filter.

Sequence Diagram

sequenceDiagram
    participant OS as Windows SEH
    participant UEF as UnHandledExceptionFilter
    participant MD as MiniDumper
    participant RC as ReleaseCrash
    participant MB as MessageBox

    OS->>UEF: Unhandled exception
    UEF->>UEF: DumpExceptionInfo()
    UEF->>MD: TriggerMiniDumpForException(Minimal)
    UEF->>MD: TriggerMiniDumpForException(Full)
    UEF->>MD: shutdownMiniDumper()
    UEF->>RC: ReleaseCrash("Unhandled exception") [NEW]
    RC->>RC: TriggerMiniDump() (guarded — dumper already shut down)
    RC->>RC: Build message (path + stack excerpt + GitHub link)
    RC->>MB: MessageBox("Game Crash", ...)
    MB-->>RC: User clicks OK
    RC->>RC: _exit(1)

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: Core/GameEngine/Source/Common/System/Debug.cpp
Line: 908

Comment:
**NULL instead of nullptr**

`NULL` is used here for the `HWND` parameter, but the codebase uses `nullptr` for null pointer literals. The original code used `nullptr` for this same parameter; this change introduces an inconsistency.

```suggestion
	::MessageBox(nullptr, buff, "Game Crash", MB_OK|MB_SYSTEMMODAL|MB_ICONERROR);
```

**Rule Used:** Use nullptr instead of NULL for null pointer liter... ([source](https://app.greptile.com/review/custom-context?memory=c69cf1a9-c69a-4330-a013-69bb5d6701da))

**Learnt From**
[TheSuperHackers/GeneralsGameCode#2067](https://github.com/TheSuperHackers/GeneralsGameCode/pull/2067#discussion_r2703746722)

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: Core/GameEngine/Source/Common/System/Debug.cpp
Line: 959

Comment:
**NULL instead of nullptr**

`NULL` is used for the `HWND` parameter to `MessageBoxW`, which expects a pointer type. Use `nullptr` to stay consistent with the project style and the original code.

```suggestion
		::MessageBoxW(nullptr, fullMessage.str(), prompt.str(), MB_OK|MB_SYSTEMMODAL|MB_ICONERROR);
```

**Rule Used:** Use nullptr instead of NULL for null pointer liter... ([source](https://app.greptile.com/review/custom-context?memory=c69cf1a9-c69a-4330-a013-69bb5d6701da))

**Learnt From**
[TheSuperHackers/GeneralsGameCode#2067](https://github.com/TheSuperHackers/GeneralsGameCode/pull/2067#discussion_r2703746722)

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: Core/GameEngine/Source/Common/System/Debug.cpp
Line: 757

Comment:
**Comment date references 2025**

The comment date `06/01/2025` is prior to the current year (2026). All three newly added comment headers in this file carry the same 2025 date (`extractCrashLocation` at line 757, `ReleaseCrash` at line 866, and `ReleaseCrashLocalized` at line 935). These should be updated to a 2026 date.

```suggestion
// TheSuperHackers @bugfix JohnsterID 06/01/2026 Helper function to extract crash location from stack trace.
```

**Rule Used:** What: Flag newly created code comments that refere... ([source](https://app.greptile.com/review/custom-context?memory=fd72a556-4fd8-4db4-8b08-8e51516a64ad))

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: "Fix review feedback:..."}