build(cmake): Add retail compatibility option in CMake config

[tintinhamans]

This pull request adds RTS_BUILD_OPTION_RETAIL_COMPATIBLE_GAME configuration option to cmake/config-build.cmake to make it easier to build retail or non-retail.

Will eventually be used for #2322

[greptile-apps]

Greptile Summary

This PR adds a default-enabled CMake option for retail-compatible game logic and reports it through CMake’s feature summary.

• Disabling the option propagates seven RETAIL_COMPATIBLE_* compile definitions through core_config.
• The definitions select non-retail CRC, save-transfer, pathfinding, circle-fill, networking, and AI-group behavior.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename	Overview
cmake/config-build.cmake	Adds and advertises the retail-compatibility option, applying opt-out compile definitions through the shared interface configuration target.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Option[RTS_BUILD_OPTION_RETAIL_COMPATIBLE_GAME] --> Enabled{Enabled?}
  Enabled -->|Yes| Defaults[Use retail-compatible header defaults]
  Enabled -->|No| CoreConfig[Set compatibility macros to 0 on core_config]
  CoreConfig --> Shared[Shared Core target configuration]
  Shared --> Generals[Generals targets]
  Shared --> ZeroHour[GeneralsMD targets]

Loading

_{Reviews (2): Last reviewed commit: "build(cmake): Group retail compatibility..." | Re-trigger Greptile}

[bobtista]

Looks good to me, is there a reason we're not just adding ALL of the gamedefines macros? eg USE_BUFFERED_IO, USE_OBSOLETE_GENERALS_CODE, TELL_COMPUTER_IDENTITY_IN_LAN_LOBBY.

Also, maybe it's pedantic, but RTS_BUILD_OPTION_RETAIL_COMPATIBLE_PATHFINDING_ALLOCATION is probably a CMakeDependentOption of RTS_BUILD_OPTION_RETAIL_COMPATIBLE_PATHFINDING. Not needed though, this works as is.

[bobtista]

Should we revive this one? Are we using RTS_BUILD_OPTION_RETAIL_COMPATIBLE_GAME? adding ALL of the gamedefines macros? If the individual switches remain, PATHFINDING_ALLOCATION should be dependent on PATHFINDING, and CI should compile at least one non-default configuration.

[tintinhamans]

Revived and simplified this based on the feedback.

The individual switches have been replaced with a single RTS_BUILD_OPTION_RETAIL_COMPATIBLE_GAME option. Disabling it turns off all current RETAIL_COMPATIBLE_* defines.

I realized I didn't need to define every GameDefines.h macro as a CMake option because they can already be accessed with RTS_FLAGS.

[bobtista]

Should we have at least one of the RTS_BUILD_OPTION_RETAIL_COMPATIBLE_GAME set to OFF for ci?

[tintinhamans]

Should we have at least one of the RTS_BUILD_OPTION_RETAIL_COMPATIBLE_GAME set to OFF for ci?

Was planning on doing that in a follow-up PR.

[xezon]

Makes sense.

[xezon]

Can clarify that disabling this will make the game benefit from the full wrath of fixes.

[xezon]

Has unaddressed comments. Needs rebase