Skip to content

perf(particlesys): Batch same type particles to reduce cost of particle rendering by 15 to 30% #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mauller wants to merge 7 commits into
base: main
Choose a base branch
from
+191 −95
Open

perf(particlesys): Batch same type particles to reduce cost of particle rendering by 15 to 30% #3155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aef58c7
chore(particlesys): Refactor point count into a class variable, ready…
Mauller Aug 14, 2026
d54cbc8
perf(particlesys): Implement batched rendering for particles (#)
Mauller Aug 14, 2026
7fc3cdb
refactor(particlesys): Use refCountPtr objects to hold ref counted te…
Mauller Aug 20, 2026
2d7b721
refactor(particlesys): Remove unnecessary null checks on pointGroup a…
Mauller Aug 20, 2026
b69ee13
refactor(particlesys): Allow the batching and rendering of untextured…
Mauller Aug 30, 2026
17b1687
Review update
Mauller Sep 3, 2026
2cf39ec
make particle batch handling functions pass const references
Mauller Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions Core/GameEngine/Include/GameClient/ParticleSys.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ class ParticleSystemTemplate : public MemoryPoolObject, protected ParticleSystem

void validate();

AsciiString getName() const { return m_name; }
const AsciiString& getName() const { return m_name; }

// This function was made const because of update modules' module data being all const.
ParticleSystem *createSlaveSystem( Bool createSlaves = TRUE ) const ; ///< if returns non-null, it is a slave system for use
Expand Down Expand Up @@ -607,15 +607,16 @@ class ParticleSystem : public MemoryPoolObject,
void setInitialDelay( UnsignedInt delay ) { m_delayLeft = delay; }

const AsciiString& getParticleTypeName() const { return m_particleTypeName; } ///< return the name of the particles
const Bool isUsingDrawables() const { return m_particleType == DRAWABLE; }
const Bool isUsingStreak() const { return m_particleType == STREAK; }
const Bool isUsingSmudge() const { return m_particleType == SMUDGE; }
const Bool isUsingVolumeParticles() const { return m_particleType == VOLUME_PARTICLE; }
const UnsignedInt getVolumeParticleDepth() const { return m_volumeParticleDepth; }
Bool isUsingParticles() const { return m_particleType == PARTICLE; }
Bool isUsingDrawables() const { return m_particleType == DRAWABLE; }
Bool isUsingStreak() const { return m_particleType == STREAK; }
Bool isUsingSmudge() const { return m_particleType == SMUDGE; }
Bool isUsingVolumeParticles() const { return m_particleType == VOLUME_PARTICLE; }
UnsignedInt getVolumeParticleDepth() const { return m_volumeParticleDepth; }

Bool shouldBillboard() { return !m_isGroundAligned; }
Bool shouldBillboard() const { return !m_isGroundAligned; }

ParticleShaderType getShaderType() { return m_shaderType; }
ParticleShaderType getShaderType() const { return m_shaderType; }

void setSlave( ParticleSystem *slave ); ///< set a slave system for us
ParticleSystem *getSlave() { return m_slaveSystem; }
Expand Down
8 changes: 8 additions & 0 deletions Core/GameEngineDevice/Include/W3DDevice/GameClient/W3DParticleSys.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,21 @@ class W3DParticleSystemManager : public ParticleSystemManager
virtual Int getOnScreenParticleCount() override { return m_onScreenParticleCount; }

private:
Bool finishedBatch(const ParticleSystem& system, const RefCountPtr<TextureClass>& texture);
void initializeBatch(const ParticleSystem& system, const RefCountPtr<TextureClass>& texture);
void flushParticleBatch(RenderInfoClass& rinfo, UnsignedInt& pointCount);

enum { MAX_POINTS_PER_GROUP = 512 };

RefCountPtr<TextureClass> m_batchTexture; ///< the texture used as the drawing surface for batched particle draws
PointGroupClass *m_pointGroup; ///< the point group that contains all of the particles
StreakLineClass *m_streakLine; ///< the streak class that contains all of the streaks
ShareBufferClass<Vector3> *m_posBuffer; ///< array of particle positions
ShareBufferClass<Vector4> *m_RGBABuffer; ///< array of particle color and alpha
ShareBufferClass<float> *m_sizeBuffer; ///< array of particle sizes
ShareBufferClass<uint8> *m_angleBuffer; ///< array of particle orientations

ParticleSystemInfo::ParticleShaderType m_batchShaderType;
Bool m_readyToRender; ///< if true, it is OK to render
Bool m_batchBillboard;
};
Loading
Loading