fix(htree): Reject invalid W3D hierarchy pivot counts

[CryoTheRenegade]

HTreeClass::Load_W3D expects every loaded hierarchy to contain at least one pivot because later code accesses Pivot[0].

Previously, a count of zero skipped allocation but allowed loading to continue. Malformed pre-3.0 files could also reach that state by setting NumPivots to UINT32_MAX, which wraps to zero when the loader adds the synthetic root pivot.

This change validates the adjusted pivot count before allocation. Counts below one now return LOAD_ERROR, while valid hierarchies follow the existing allocation and loading path.

This prevents corrupt or crafted W3D assets from leaving an HTreeClass with no pivot storage and crashing when Pivot[0] is used.

Found by clang-tidy.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Reject overflowing pre-3.0 W3D hierarchy pivot counts

🐞 Bug fix 🕐 Less than 10 minutes

AI Description

• Rejects malformed pre-3.0 hierarchy counts before synthetic-root arithmetic can overflow.
• Guards synthetic-root initialization against missing or empty pivot allocations.

Diagram

graph TD
  A["W3D Header"] --> B{"Pre-3.0?"} -->|Yes| C{"Count max?"} -->|No| E["Allocate Pivots"] --> F["Read Pivots"] --> G{"Synthetic root?"} -->|Yes, valid| H["Initialize Root"]
  B -->|No| E
  C -->|Yes| D["Load Error"]

Loading

High-Level Assessment

The current defense-in-depth approach is appropriate: reject the invalid count before arithmetic, then enforce the allocation invariant at the write site. Relying on only the downstream guard would avoid the null write but would not reject the malformed header at its source.

Files changed (1) +7 / -0

Bug fix (1) +7 / -0

htree.cppPrevent legacy pivot-count overflow and null writes +7/-0

Prevent legacy pivot-count overflow and null writes

• Rejects UINT32_MAX pivot counts before pre-3.0 synthetic-root adjustment can wrap to zero. Verifies pivot storage exists and contains at least one element before writing the synthetic RootTransform pivot.

Core/Libraries/Source/WWVegas/WW3D2/htree.cpp

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can switch off images and animations for a plain-text comment

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[greptile-apps]

Greptile Summary

The PR hardens W3D hierarchy loading against a pre-3.0 pivot-count overflow by rejecting the resulting zero count before allocation.

• Requires every loaded hierarchy to contain at least one pivot after legacy root adjustment.
• Allocates the pivot array only after validating the adjusted count.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains within the eligible follow-up scope.

No blocking failure remains.

Important Files Changed

Filename	Overview
Core/Libraries/Source/WWVegas/WW3D2/htree.cpp	Validates the adjusted hierarchy pivot count before allocating and reading pivots, preventing the malformed pre-3.0 null-write path.

_{Reviews (2): Last reviewed commit: "style(htree): Remove redundant validatio..." | Re-trigger Greptile}

[xezon]

The change title and description are outdated.

[CryoTheRenegade]

updated