Skip to content

bugfix(particlesys): Delay particle system destruction to prevent orphaning slaved finite-lifetime particle systems #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 1 commit into from
Aug 31, 2026
+13 −2
Merged

bugfix(particlesys): Delay particle system destruction to prevent orphaning slaved finite-lifetime particle systems #3238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions Core/GameEngine/Source/GameClient/System/ParticleSys.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2125,9 +2125,15 @@ Bool ParticleSystem::update( Int localPlayerIndex )
// If we have been "destroyed", wait for all of our particles to die off,
// then destroy ourselves (return false).
//
// TheSuperHackers @bugfix Mauller 30/08/2026 Delay destruction to prevent finite-lifetime slave particle systems being orphaned.
// Orphaned particle systems lack positional data, render at the world origin and do not complete their full lifecycle.
if (m_isDestroyed && !m_systemParticlesHead)
return false;
{
if (m_slaveSystem && !m_slaveSystem->isSystemForever())
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Comment thread
xezon marked this conversation as resolved.
return true;

return false;
}

// monitor particle system lifetime
if (m_isForever == false)
Expand All @@ -2142,7 +2148,12 @@ Bool ParticleSystem::update( Int localPlayerIndex )

// check if time is up
if (m_systemLifetimeLeft == 0)
Comment thread
xezon marked this conversation as resolved.
return false;
{
if (m_slaveSystem && !m_slaveSystem->isSystemForever())
m_isDestroyed = true;
else
return false;
}
}

return true;
Expand Down
Loading