chore(lib): Implement Usp10Loader class

[OmarAglan]

• Relates to feat(text): Shape complex single line UI text #3231

Adds a small Windows-only runtime loader for the Uniscribe entry points required by the complex-text renderer.

The loader resolves the functions from the system usp10.dll at runtime and reports failure to callers when Uniscribe is unavailable. This allows #3231 to retain the existing per-character renderer as its fallback while removing the compile-time dependency on usp10.h and usp10.lib, which are missing from the VC6 SDK.

The loader also provides synchronized shutdown cleanup; #3231 calls it from WW3D::Shutdown().

Cross-platform text shaping remains outside this focused compatibility change.

The stacked result was validated with:

• Visual Studio 2022 x86 Release builds of Generals and Zero Hour
• The repository’s portable VC6 toolchain for Generals and Zero Hour
• Verification that the resulting executables do not statically import usp10.dll
• git diff --check

The change was developed with AI assistance, then manually reviewed against the nearby runtime-loader pattern and the official Windows SDK function declarations.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Load required Uniscribe APIs dynamically on Windows

✨ Enhancement 🕐 10-20 Minutes

AI Description

• Loads five Uniscribe APIs dynamically from Windows’ system usp10.dll.
• Reports unavailable libraries or exports so renderers can retain existing fallbacks.
• Provides SDK-independent declarations compatible with the portable VC6 toolchain.

Diagram

graph TD
    Renderer["Text renderer"] --> Loader["Usp10 loader"] --> Attempt{"First attempt?"}
    Attempt -->|Yes| DLL["System usp10.dll"] --> Exports["Five exports"] --> Status["Cached status"]
    Attempt -->|No| Status

Loading

High-Level Assessment

The runtime-loader approach is appropriate for this compatibility-focused change: it avoids unavailable VC6 SDK headers and import libraries, prevents a static usp10.dll dependency, loads only from the Windows system directory, and exposes failure for the renderer’s existing fallback. Static linking and linker delay-loading were considered but would retain toolchain or import-table dependencies, while a general-purpose loader abstraction would add unnecessary scope for five tightly related APIs.

Files changed (3) +184 / -0

Enhancement (2) +182 / -0

Usp10Loader.cppResolve and wrap Uniscribe exports at runtime +111/-0

Resolve and wrap Uniscribe exports at runtime

• Implements thread-safe, one-time loading of 'usp10.dll' from the Windows system directory and resolves five required exports. Wrapper methods return 'E_FAIL' or 'nullptr' when the DLL or any required function is unavailable, allowing callers to fall back safely.

Core/Libraries/Source/WWVegas/WWLib/Usp10Loader.cpp

Usp10Loader.hDeclare SDK-independent Uniscribe wrappers +71/-0

Declare SDK-independent Uniscribe wrappers

• Defines the minimal opaque types, flags, function signatures, and loader state required by the complex-text renderer without including 'usp10.h'. The public static API mirrors the required Uniscribe calls while hiding dynamic-resolution details.

Core/Libraries/Source/WWVegas/WWLib/Usp10Loader.h

Other (1) +2 / -0

CMakeLists.txtBuild the Uniscribe loader on Windows +2/-0

Build the Uniscribe loader on Windows

• Adds the loader implementation and header to WWLib’s Windows-only source list, keeping non-Windows builds unaffected.

Core/Libraries/Source/WWVegas/WWLib/CMakeLists.txt

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[greptile-apps]

Greptile Summary

Adds a Windows-only WWLib service that dynamically loads Uniscribe and exposes synchronized wrappers without creating a static usp10.dll dependency.

• Registers the loader sources with the Windows core_wwlib target.
• Resolves the required Uniscribe entry points on first use and reports unavailable functions through failure return values.
• Provides synchronized resource release and resets loader state for later reuse.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains within the eligible follow-up review scope.

No blocking failure remains.

Important Files Changed

Filename	Overview
Core/Libraries/Source/WWVegas/WWLib/CMakeLists.txt	Adds the loader implementation and header to core_wwlib only for Windows builds.
Core/Libraries/Source/WWVegas/WWLib/Usp10Loader.cpp	Implements synchronized lazy loading, entry-point forwarding, failure handling, and unloading for usp10.dll.
Core/Libraries/Source/WWVegas/WWLib/Usp10Loader.h	Declares the local Uniscribe-compatible types, constants, wrappers, and static loader state.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    Caller[Renderer caller] --> Wrapper[Usp10Loader wrapper]
    Wrapper --> Lock[Acquire critical section]
    Lock --> Attempt{Load attempted?}
    Attempt -->|No| SystemDir[Resolve system directory]
    SystemDir --> DLL[Load usp10.dll]
    DLL --> Exports[Resolve Uniscribe exports]
    Attempt -->|Yes| Ready{Module available?}
    Exports --> Ready
    Ready -->|Yes| Invoke[Invoke resolved entry point]
    Ready -->|No| Fallback[Return failure for renderer fallback]
    Shutdown[Engine shutdown] --> Unload[Unload and clear pointers]
    Unload --> Lock

Loading

_{Reviews (6): Last reviewed commit: "feat(system): Load Uniscribe at runtime" | Re-trigger Greptile}

[OmarAglan]

@codex

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 68a4beb2f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[xezon]

Meaning of USP10

USP10 stands for Uniscribe Script Processor version 1.0. This name reflects its primary function within the Windows operating system.

Functionality

• Uniscribe: This component is responsible for handling the proper formatting of Unicode text, especially for complex scripts.
• Script Processor: It processes text layout and rendering, ensuring that text appears correctly on the screen.

Versioning

• The "10" in USP10 indicates that it is the first version of the Uniscribe Script Processor, which is integral to the Windows operating system's ability to manage various languages and scripts.

[xezon]

If microsoft bumps the version number... 😆 Looks like they did not in 28 years.

[OmarAglan]

well, that's true, this is very old tech from win 98SE era, i suppose it now got replaced with direct write, this is adding support for Arabic or rtl language and bidi without rewriting the backend, see https://learn.microsoft.com/en-us/windows/win32/intl/uniscribe

also, it has serval minor versions, see https://scripts.sil.org/cms/scripts/page.php?id=uniscribeversions&site_id=nrsi

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61fa2ccf19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[xezon]

Looks right

[OmarAglan]

i think i fixed most of the issues, maybe we need a second opinion, as i cant see any new issues!