Skip to content

bugfix: Evacuate button positions are now consistent across all ground transport vehicles #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stubbjax wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: Evacuate button positions are now consistent across all ground transport vehicles #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GeneralsZH/Data/INI/CommandSet/AmericaCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ CommandSet AmericaVehicleAmbulanceCommandSet
5 = Command_TransportExit
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_Evacuate
9 = Command_Evacuate
10 = Command_AmbulanceCleanupArea
11 = Command_AttackMove
13 = Command_Guard
Expand Down
2 changes: 1 addition & 1 deletion GeneralsZH/Data/INI/CommandSet/AmericaLaserCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ CommandSet Lazr_AmericaVehicleAmbulanceCommandSet
5 = Command_TransportExit
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_Evacuate
9 = Command_Evacuate
10 = Command_AmbulanceCleanupArea
11 = Command_AttackMove
13 = Command_Guard
Expand Down
2 changes: 1 addition & 1 deletion GeneralsZH/Data/INI/CommandSet/AmericaSuperWeaponCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ CommandSet SupW_AmericaVehicleAmbulanceCommandSet
5 = Command_TransportExit
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_Evacuate
9 = Command_Evacuate
10 = Command_AmbulanceCleanupArea
11 = Command_AttackMove
13 = Command_Guard
Expand Down
6 changes: 3 additions & 3 deletions GeneralsZH/Data/INI/CommandSet/ChinaCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,16 @@ CommandSet ChinaTroopCrawlerCommandSet
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_TransportExit
9 = Command_EmptyCrawler
9 = Command_Evacuate

@xezon xezon Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command_EmptyCrawler

11 = Command_AttackMove
14 = Command_Stop
End

CommandSet ChinaListeningOutpostCommandSet
1 = Command_TransportExit
2 = Command_TransportExit
9 = Command_Evacuate

@xezon xezon Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command_EmptyCrawler

11 = Command_AttackMove
12 = Command_EmptyCrawler
13 = Command_Guard
14 = Command_Stop
End
Expand Down Expand Up @@ -134,7 +134,7 @@ CommandSet ChinaTankOverlordBattleBunkerCommandSet
3 = Command_TransportExit
4 = Command_TransportExit
5 = Command_TransportExit
6 = Command_Evacuate
9 = Command_Evacuate
11 = Command_AttackMove
13 = Command_Guard
14 = Command_Stop
Expand Down
6 changes: 2 additions & 4 deletions GeneralsZH/Data/INI/CommandSet/ChinaInfantryCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ CommandSet Infa_ChinaTroopCrawlerCommandSet
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_TransportExit
9 = Command_EmptyCrawler
9 = Command_Evacuate

@xezon xezon Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command_EmptyCrawler

11 = Command_AttackMove
14 = Command_Stop
End
Expand All @@ -330,10 +330,8 @@ CommandSet Infa_ChinaListeningOutpostCommandSet
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_TransportExit
; 9 = Command_TransportExit
; 10 = Command_TransportExit
9 = Command_Evacuate

@xezon xezon Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command_EmptyCrawler

11 = Command_AttackMove
12 = Command_EmptyCrawler
13 = Command_Guard
14 = Command_Stop
End
Expand Down
2 changes: 1 addition & 1 deletion GeneralsZH/Data/INI/CommandSet/ChinaNukeCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,8 @@ End
CommandSet Nuke_ChinaListeningOutpostCommandSet
1 = Command_TransportExit
2 = Command_TransportExit
9 = Command_Evacuate

@xezon xezon Jul 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command_EmptyCrawler

@Stubbjax Stubbjax Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rationale for not streamlining the command/icon?

@xezon xezon Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a separate change, and vehicles should use Command_EmptyCrawler (it shows a vehicle), structures use Command_Evacuate (it shows a building).

@Stubbjax Stubbjax Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should it be a separate change when the intended outcome is that all ground transport vehicles can use the evacuate command within the same selection?

The different icon is not important; the action is the same and it should be consistent. Command_EmptyCrawler should be obsoleted.

@xezon xezon Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should it be a separate change when the intended outcome is that all ground transport vehicles can use the evacuate command within the same selection?

Ok it is fair point. We can have it one change then.

The different icon is not important; the action is the same and it should be consistent. Command_EmptyCrawler should be obsoleted.

I vote for the crawler image for vehicles. It fits better. Maybe we need a vote then.

@Stubbjax Stubbjax Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That still does not explain how it is helpful for the user. If the action is the same, the icon should be the same unless there is a strong enough justification for otherwise.

@xezon xezon Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just preference. I like the crawler image. It is closer to what happens: evacuating the vehicle. It is not evacuating a building.

@Stubbjax Stubbjax Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal preference should not supersede the correct logical approach. The evacuate icon represents evacuation, which is what the action does. The object being evacuated from in the icon is irrelevant.

@xezon xezon Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who defined that? EA added 3 different evac button and it mismatches your logical approach. I understand your perspective and it is reasonable, but it is also perfectly reasonable to have a different opinion than yours.

@Stubbjax Stubbjax Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did EA make a perfect game with no mistakes? They clearly had an Command_EmptyCrawler command which was likely distinct in behaviour from Command_Evacuate at some point, but the behaviour was ultimately dropped and the command was not appropriately replaced. I would also suggest a similar thing happened with the Chinook, where it would maybe have unloaded objects via ropes as depicted in the icon. It is extremely unlikely they would intentionally have had a unique Chinook unload button designed otherwise.

11 = Command_AttackMove
12 = Command_EmptyCrawler
13 = Command_Guard
14 = Command_Stop
End
4 changes: 2 additions & 2 deletions GeneralsZH/Data/INI/CommandSet/GLACommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ CommandSet GLAVehicleBattleBusCommandSet
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_TransportExit
10 = Command_Evacuate
9 = Command_Evacuate
11 = Command_AttackMove
13 = Command_Guard
14 = Command_Stop
Expand All @@ -151,7 +151,7 @@ CommandSet GLAVehicleTechnicalCommandSet
3 = Command_TransportExit
4 = Command_TransportExit
5 = Command_TransportExit
10 = Command_Evacuate
9 = Command_Evacuate
11 = Command_AttackMove
13 = Command_Guard
14 = Command_Stop
Expand Down
8 changes: 4 additions & 4 deletions GeneralsZH/Data/INI/CommandSet/GLADemoCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ CommandSet Demo_GLAVehicleBattleBusCommandSet
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_TransportExit
10 = Command_Evacuate
9 = Command_Evacuate
11 = Command_AttackMove
13 = Command_Guard
14 = Command_Stop
Expand Down Expand Up @@ -276,7 +276,7 @@ CommandSet Demo_GLAVehicleTechnicalCommandSet
3 = Command_TransportExit
4 = Command_TransportExit
5 = Command_TransportExit
10 = Command_Evacuate
9 = Command_Evacuate
11 = Command_AttackMove
13 = Command_Guard
14 = Command_Stop
Expand All @@ -301,7 +301,7 @@ CommandSet Demo_GLAVehicleTechnicalCommandSetUpgrade
3 = Command_TransportExit
4 = Command_TransportExit
5 = Command_TransportExit
10 = Command_Evacuate
9 = Command_Evacuate
11 = Command_AttackMove
12 = Demo_Command_TertiarySuicide
13 = Command_Guard
Expand Down Expand Up @@ -520,7 +520,7 @@ CommandSet Demo_GLAVehicleBattleBusCommandSetUpgrade
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_TransportExit
10 = Command_Evacuate
9 = Command_Evacuate
11 = Command_AttackMove
12 = Demo_Command_TertiarySuicide
Comment thread
xezon marked this conversation as resolved.
13 = Command_Guard
Expand Down
2 changes: 1 addition & 1 deletion GeneralsZH/Data/INI/CommandSet/GLAStealthCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ CommandSet Slth_GLAVehicleBattleBusCommandSet
6 = Command_TransportExit
7 = Command_TransportExit
8 = Command_TransportExit
10 = Command_Evacuate
9 = Command_Evacuate
11 = Command_AttackMove
13 = Command_Guard
14 = Command_Stop
Expand Down
2 changes: 1 addition & 1 deletion GeneralsZH/Data/INI/CommandSet/MiscCommandSet.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ CommandSet CivilianVehicleLimoCommandSet
3 = Command_TransportExit
4 = Command_TransportExit
5 = Command_TransportExit
6 = Command_Evacuate
9 = Command_Evacuate
14 = Command_Stop
End

Expand Down