bugfix: Remove extra zero from in-game message delay - #175
Open
bobtista wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change corrects
MessageDelayMSfrom 75000 to 7500 in both Generals and Zero Hour.The engine currently converts this value incorrectly, so the bad data is mostly hidden. TheSuperHackers/GeneralsGameCode#3133 fixes that conversion; with 75000 left in place, messages remain at full alpha for 75 seconds. At 7500 they hold for 7.5 seconds before the existing fade.
This must merge before or together with TheSuperHackers/GeneralsGameCode#3133. Related engine issue: TheSuperHackers/GeneralsGameCode#3131.