bugfix: Contamination fields render incorrectly on uneven terrain - #177
Draft
stephanmeesters wants to merge 2 commits into
Draft
bugfix: Contamination fields render incorrectly on uneven terrain#177stephanmeesters wants to merge 2 commits into
stephanmeesters wants to merge 2 commits into
Conversation
4 tasks
stephanmeesters
added
Gen
stephanmeesters
changed the title
stephanmeesters
added
Bug
stephanmeesters
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies particle systems of contamination field type to render correctly on uneven terrain. The new terrain conforming feature is enabled by setting
IsTerrainConforming = YESon a particle system template.List of changed particle systems
AnthraxFieldLargeAnthraxFieldMediumAnthraxFieldSmallAnthraxGammaPuddleContinuousAnthraxGammaPuddleLargeAnthraxPuddleAnthraxPuddleContinuousAnthraxPuddleLargeCleanupPuddleGC_Chem_AnthraxFieldGammaLargeGC_Chem_AnthraxFieldGammaMediumGC_Chem_AnthraxGammaFieldLargeGC_Chem_AnthraxGammaFieldMediumGC_Chem_AnthraxGammaFieldSmallGC_Chem_ToxinPuddleNukeRadiationInitialPoisonFieldLargePoisonFieldMediumPoisonFieldSmallRadiationFieldLargeRadiationFieldMediumRadiationFieldSmallToxinPuddleToxinPuddleContinuousToxinPuddleLargeToxinTankPuddleBefore
before.mp4
After
after.mp4
Notes
The first commit changes only the particle systems for which this feature is enabled. The second commit sets the opposite value
IsTerrainConforming = NOfor all of the unaffected particle systems.Can be rebase- or squash merged by maintainer preference.
Todo