Repository navigation
fix: support verified existing OpenChamber listeners - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An existing OpenCode server bound to a wildcard address could be reached safely through loopback, but the OpenChamber destination refused it. Accept that existing listener only when it is the sole inode serving the literal local origin and the same process owns the expected database. No listener, port, exposure, authentication or policy is changed. Exact/wildcard ambiguity and shared listeners still fail closed before sending authentication.
Validation: 57 focused tests passed; independent review reran the same suite, with one optional Textual prerequisite skipped in that QA environment. Ruff and diff checks passed. Read-only validation against the actual local server proved PID/UID/socket/database/version and found the previously migrated session. DEV11 also corrects the documented cause of the unrelated frontend listing failure: legacy permission rules use v1 keys. Their data conversion requires separate explicit approval and is not performed by this PR.