Repository navigation
test: verify AI SDK image tool continuations - #557
Merged
Merged
Conversation
Measure exact inline PNG and correlated tool history across both chat bases and all four registered adapters. Verify fresh continuation admission and first/second persistence failure boundaries through the actual pinned client without changing production behavior. Refs: #556 Assisted-by: Codex Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
github-actions
Bot
added
ai-review-requested
sjungwon03-ai
approved these changes
Oct 29, 2026
sjungwon03-ai
left a comment
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Review summary
Verdict: Approved
- Reviewed: Complete test and documentation diff, shared fixtures, native image/tool history, fresh continuation admission, persistence failures, and operational privacy; no blocking issues found.
- Checks: All three GitHub checks passed. Independently ran all 160 new tests (160 passed),
npm run typecheck,python3 scripts/check.py, andgit diff --check; all passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #556. Refs #116; Jev #7 remains unresolved.
The pinned AI SDK already had separate image and tool probes. This change composes them through actual generateText/streamText sockets on /v1 and /api/v1, delegated OpenRouter and managed OpenAI/Anthropic/Gemini. Exact first/continued native history retains inline PNG MIME/bytes/text order and tool ID/name/argument/result correlation. Nonstream parallel lookups finish in reverse order; streams run one ordinary read function.
Fresh continuation auth failure, implicit/model/provider Deny and limit exhaustion block the second provider/secret access after application tools have run. Required usage/outcome-audit failure on either request withholds nonstream output or actual final stream usage/DONE. Per-attempt identities/counters and operational content/credential privacy remain intact. Client events/summaries are not persistence or billed-cost evidence; a later failure cannot undo completed tools/provider work.
Plan: 556-ai-sdk-image-tools. Contract: inline-image tool continuations. Reproduction.
Validation:
Limits: synthetic credential-free registered transports, pinned clients, one canonical inline PNG and ordinary tool loops. Empty-only download plans and bounded local endpoint fetches do not certify remote media behavior. Signed Gemini, richer media/tools, live vision, other versions/endpoints and full #116 remain separate. Production code, six pins, dependencies and storage remain unchanged.