Skip to content

Deploy #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madcowfred merged 1 commit into from
Mar 29, 2026
Merged

Deploy #1736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions apps/frontend/components/professions/recipes/View.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@
characters = [];
const collectorIds =
settingsState.value.professions.collectingCharactersV2?.[profession.id] || [];
if (collectorIds.length > 0) {
const validCollectors = collectorIds
.map((collectorId) => userState.general.characterById[collectorId])
.filter((char) => !!char);
if (validCollectors.length > 0) {
characters.push(null);
characters.push(
...collectorIds.map((collectorId) => userState.general.characterById[collectorId])
);
characters.push(...validCollectors);
}

const professionCharacters = userState.general.visibleCharacters.filter((char) =>
Expand Down Expand Up @@ -171,7 +172,7 @@
>
</th>
{#each characters as character}
{#if character !== null}
{#if character}
<th class="character-icon">
<div class="faction{character.faction}">
<ClassIcon
Expand Down Expand Up @@ -207,8 +208,8 @@
</tr>

{#each abilities as ability}
{@const recipes = wowthingData.static.skillLineAbilityItems[ability.id]}
{@const recipeItem = wowthingData.items.items[recipes?.[0]]}
{@const recipes = wowthingData.static.skillLineAbilityItems[ability.id] || []}
{@const recipeItem = wowthingData.items.items[recipes[0]]}
<tr data-id={ability.id}>
<td class="source">
{#if recipeItem}
Expand Down
Loading