Repository navigation
Conversation
…and new scripts - Added a pre-commit hook to check for explicit test marks in Python and JavaScript files. - Updated `package.json` to include new test commands for unit tests and browser tests. - Introduced `check_test_marks.py` for Python and `check-test-marks.mjs` for JavaScript to validate test classifications. - Created `select_checks.py` to determine the scope of heavy checks based on the PR diff. - Added new scripts for listing browser tests and running unit tests with specified layers and hardware. - Updated `pyproject.toml` to register new pytest markers for hardware and CI layers. - Enhanced documentation to reflect changes in test classification and validation processes. Signed-off-by: wangyu <410167048@qq.com>
11 tasks
## summary - Merge upstream CodeQL and Markdown text changes, preserving both security-scanning and cross-language classification documentation. - Register CPU marks and frontend/browser catalog entries for the newly merged tests without changing their layer or gate behavior. ## validation - 134 focused Python CI/security regression cases passed on Windows. - 827 frontend unit tests passed; TypeScript and i18n checks passed. - 13 text CLI cases passed in WSL against the local working tree. - Shared pre-commit checks, actionlint and staged diff checks passed. Refs: ThinkFlowLab#273
- Updated the `pre-commit.yml` workflow file to remove bilingual descriptions from the outputs, simplifying the language to English only for clarity. - Adjusted the names of the output parameters to maintain consistency and improve readability. No functional changes were made to the workflow logic. Signed-off-by: wangyu <410167048@qq.com>
wangtiance
reviewed
Nov 19, 2026
wangtiance
left a comment
Collaborator
There was a problem hiding this comment.
本轮重点检查了硬件标记审计、前端分类入口和可复用静态工作流。当前 head 为 93db62c;这是静态代码审阅,未在本机执行测试,也不代表已经通过合并验收。
目前需要先同步 main 再复核工作流迁移。#349 已于 11 月 19 日合入 main,而本分支仍基于它之前的版本,GitHub 当前报告存在合并冲突。main 的 static job 已包含 merge_group 的完整历史 checkout、MERGE_GROUP_BASE_SHA、base-to-head pre-commit 以及范围判定;本 PR 新抽出的 pre-commit.yml 尚不包含这些处理。解决冲突时请把 #349 的这些逻辑一起迁入新工作流,并保留对应范围测试,避免抽取静态任务时丢掉合并队列支持。
当前 head 的 check-runs API 只返回 reviewer route 成功,不能据此认定 Release checks 已通过。建议同步后在新的测试合并提交上补齐静态、Python、前端和浏览器检查,再验证 merge-group 的纯文档组合及包含前序代码变更的组合。
分类实现保留默认全量测试的方向符合 #273 当前过渡阶段要求;本轮未确认新的硬件分类阻塞缺陷。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a hardware-platform axis and explicit classification checks across Python tests, frontend unit files and browser journeys, without activating a reduced CI selection.
cpu,cuda,rocm,xpuandnpu; explicitly tag current Python tests. Genericgpu, SKU and card-count marks are not supported.pre-commit.yml. Preserve static-before-heavy dependencies, documentation-only receipts and the stable release aggregate. Group supporting scripts underscripts/pre-commit/.Latest main
526ece2ais merged, including #347 and #344. The documentation conflict preserves both security-scanning and classification guidance. Newly added Python, frontend and browser tests are registered with explicit CPU classifications; the new Markdown browser gate remains enabled.Validation
On merge commit
3449083a:--noEmit, mark/browser inventories, i18n, shared pre-commit checks (including actionlint), and staged diff checks passed.pillow_heif; the existing WSL environment supplied the application dependencies.Full application pytest, browser UI/media journeys and real-provider acceptance were not run. Hosted Actions results remain to be checked. Windows Node 24.14.0 is older than the repository's pinned CI version.
Refs #273 (PR-4b, with cross-language classification and pre-commit workflow organization).