Skip to content

fix: apply CEI ordering to auction bids#570

Open
sirakinb wants to merge 1 commit into
ThinkLikeAFounder:mainfrom
sirakinb:codex/fix-auction-place-bid-cei
Open

fix: apply CEI ordering to auction bids#570
sirakinb wants to merge 1 commit into
ThinkLikeAFounder:mainfrom
sirakinb:codex/fix-auction-place-bid-cei

Conversation

@sirakinb
Copy link
Copy Markdown

Summary

  • persist bid records, highest bid, bidder deposit records, prior-deposit cleanup, and auction winner state before token transfers in place_bid
  • move new-bid escrow and previous-winner refund after the auction effects are committed
  • add coverage for bidder deposit records so the outbid cleanup is asserted

Tests

  • cargo fmt -p pulsar-auction-engine --check
  • cargo +1.91.1 test -p pulsar-auction-engine

Refs #553

@sirakinb sirakinb force-pushed the codex/fix-auction-place-bid-cei branch from 632f9f2 to b7e7514 Compare May 28, 2026 02:31
@sirakinb
Copy link
Copy Markdown
Author

Rebased this branch onto current main and resolved the conflict by keeping all bid/highest/winner/bidder storage effects before any token transfer.

Verification after rebase:

  • cargo +1.91.1 fmt -p pulsar-auction-engine --check
  • git diff --check
  • cargo +1.91.1 test -p pulsar-auction-engine (21 passed)

Note: the Soroban test run rewrote local snapshot artifacts; I restored that generated churn and did not include it in the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants