Merged
Conversation
all of them are better at semantic messaging than green_tick/red_dot
there is no need for this doubling since the pkg func is internal and not exported there is no nameclash
replace green tick with either of
- cli_alert_success, (looks exactly the same)
- cli_alert_info (when an info icon conveys better the idea)
fix some typos along the way (punctuation)
- replace with alert_warning where appropriate or with alert_info - fixed some typos
replace relevant instances with the bootstrapper cli_alert_info fix some typos also normalize generic file creation output
Remove the unused cli_cat_bullet() and generic cli_alert() bootstrappers. Replace remaining user-facing bullet output with semantic cli alerts and keep
move check_cli_installed() inside do_if_unquiet() so quiet message paths do not require cli before deciding whether to print. remove redundant do_if_unquiet() calls from higher-level cats helpers now that the lower-level cli wrappers own quiet handling.
move cats.R content to cli_msg.R to keep all user facing messaging functions in one place keeping them in one place will help future refactors, and avoid double use of more or less the same type of messaging (there are some similar messages that may be unified in the future)
this cleans up the messages: - for files of any type (not html, css, js), there is no reason to print to the user "automatically linked" - for downloaded/copied files, the transfer helper now owns the success message, so the follow-up dance no longer repeats the same path - remove after_creation_message_generic(), after_creation_message_any_file(), and after_creation_message_sass() because they have no production callers after add_file/add_sass_file were routed through the internal/external file helpers - keep Sass messaging in add_sass_file(), where the compilation hook is created, and clarify that the generated CSS file is automatically linked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #89
as discussed irl