Open
Conversation
The legacy author_* arguments were already marked as to-be-deprecated in docs and warning text, but they were not explicitly framed as deprecated API. Keep behavior unchanged for now and formalize the deprecation message so a later removal is clearer and easier to justify.
Member
|
@ilyaZar great, let me know when I can cherry pick / merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1155
@ColinFay no need to merge yet, I have a couple of others branches and will come up with a merge order soon
so far so good:
the first commit solves the issue
subsequent commits propose to remove or (clearly) deprecate other funcs as discussed
For cherry picking:
browser_button()get_sysreqs()use_recommended_deps()add_ui_server_files()add_rstudioconnect_file()fill_desc()legacyauthor_*args