Skip to content

fix: api endpoints for image upload, share creation,... in [[id]].js #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: api endpoints for image upload, share creation,... in [[id]].js #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions functions/api/image/[[id]].js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ const ALLOWED_VIDEO_TYPES = new Set([
"video/webm"
]);
const ALLOWED_MEDIA_TYPES = new Set([...ALLOWED_IMAGE_TYPES, ...ALLOWED_VIDEO_TYPES]);
const RATE_LIMIT_WINDOW_SECONDS = 60;
const RATE_LIMIT_MAX_UPLOADS = 20;

async function isWithinUploadRateLimit(env, request) {
const ip = request.headers.get("CF-Connecting-IP") || "unknown";
const key = "ratelimit:image-upload:" + ip;
const current = Number(await env.SHARE_KV.get(key)) || 0;
if (current >= RATE_LIMIT_MAX_UPLOADS) return false;
await env.SHARE_KV.put(key, String(current + 1), { expirationTtl: RATE_LIMIT_WINDOW_SECONDS });
return true;
}

function isAllowedOrigin(origin) {
if (!origin) return true;
Expand Down Expand Up @@ -156,6 +167,9 @@ export async function onRequest({ request, env, params }) {
if (request.method === "POST" && !id) {
const origin = request.headers.get("Origin") || "";
if (!isAllowedOrigin(origin)) return jsonResponse({ error: "origin not allowed" }, { status: 403 }, request);
if (!(await isWithinUploadRateLimit(env, request))) {
return jsonResponse({ error: "too many upload requests, please try again later" }, { status: 429 }, request);
}
const contentLength = Number(request.headers.get("Content-Length"));
if (Number.isFinite(contentLength) && contentLength > MAX_DATA_URL_CHARS + 1024) {
return jsonResponse({ error: "media upload is too large" }, { status: 413 }, request);
Expand Down
Loading