Update timezonefinder version - #3
Draft
k3vmcd wants to merge 1 commit into
Draft
Conversation
This was referenced Feb 10, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest Home Assistant Core 2024.2.x includes Python 3.12 (https://www.home-assistant.io/blog/2024/02/07/release-20242/#shipping-on-a-new-python-version)
timezonefinder supports Python 3.12 as of version 6.4.0.
Need to update the timezonefinder requirement to 6.4.0 or greater to install on the latest Home Assistant.
However, the installation currently fails as there is an issue with the h3 dependency. Some users have had success with Python 3.12.1, but Home Assistant 2024.2.0 and 2024.2.1 fails with the error:
Unable to install package timezonefinder==6.4.1: error: subprocess-exited-with-error × Building wheel for h3 (pyproject.toml) did not run successfully. │ exit code: 1 ╰─> [11 lines of output] Traceback (most recent call last): File "/tmp/pip-build-env-w4bn3qf6/overlay/lib/python3.12/site-packages/skbuild/setuptools_wrap.py", line 645, in setup cmkr = cmaker.CMaker(cmake_executable) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pip-build-env-w4bn3qf6/overlay/lib/python3.12/site-packages/skbuild/cmaker.py", line 148, in __init__ self.cmake_version = get_cmake_version(self.cmake_executable) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pip-build-env-w4bn3qf6/overlay/lib/python3.12/site-packages/skbuild/cmaker.py", line 105, in get_cmake_version raise SKBuildError(msg) from err Problem with the CMake installation, aborting build. CMake executable is /tmp/pip-build-env-w4bn3qf6/overlay/lib/python3.12/site-packages/cmake/data/bin/cmake [end of output] note: This error originates from a subprocess, and is likely not a problem with pip. ERROR: Failed building wheel for h3 ERROR: Could not build wheels for h3, which is required to install pyproject.toml-based projectsWait to merge PR until this is resolved. Related project issues:
uber/h3-py#342
uber/h3-py#326
jannikmi/timezonefinder#208
Workaround by switching to timeapi.io in the meantime (or permanently if acceptable to depend on the cloud). Working install for Home Assistant 2024.2.1 is in PR #5.