BackUp: Previous Development by ThomasNaderBMW · Pull Request #3 · ThomasNaderBMW/BMW_Graphic_Extension

ThomasNaderBMW · 2019-08-27T15:09:13Z

Bitte einfach kommentieren :)

SergejHolzmannBMW · 2019-08-29T13:38:58Z

Aus meiner Sicht fehlen noch folgende Informationen:

VehicleBasics:

color
number plate

DriverActions:

Enum mit möglichen Tätigkeiten (fahren, Zeitung lesen, schlafen, telefonieren, trinken, schimpfen,...)

Feel free to comment!

TKUsaneers · 2019-09-10T08:53:14Z

Für unser AR-HUD fehlen noch:

Kopfposition bzw. Augpunkt des Fahrers
Navigationsinformation
2.1 Geplanter Streckenverlauf
2.2 Anstehende Maneuver mit Position, Maneuvertyp (z.B. Spurwechsel, Abbiegen), und eventueller Zusatzinformation (z.B. Straßennamen, Zielspur des Spurwechsels)
FAS-Funktionen
3.1 Regelobjekt des ACC
3.2 Erkannte Engstellen
3.3 Aktivierungssignal inklusive Level
3.4 Deaktivierungssignal inklusive Level und Counter/Timer
3.5 Spurverlassenswarnung inklusive betroffene Seite
3.6 WBC: Gefährdendes Objekt, sowie Ausweich-Trajektorie (falls Level 3/4)
3.7 HOR inklusive Level
3.8 TOR inklusive Level
3.9 Nothalt inlusive Distanz bis zum Stillstand und Trajektorie
3.10 Abstandswarnung inklusive erkanntem Objekt/Hinderniss
Ist es möglich die Trajektorie nicht nur als Ankerpunkt zu bekommen, sondern, wie die normalen Spuren, als Liste von Koordinaten?

ManuelKugelmann · 2019-09-12T09:45:35Z

osi_vehicle.proto is missing includes:

import "osi_version.proto";

(and maybe import "osi_object.proto"; for LightState, although it is wrapped in MovingObject_VehicleClassification_LightState)

ManuelKugelmann · 2019-09-12T09:47:53Z

osi_vehicle.proto Vehicle has duplicate field ids:

optional InterfaceVersion version = 1;
optional VehicleBasics vehicle_basics = 1;

optional LightState vehicle_light_state = 7;
repeated VehicleAutomatedDrivingFunction vehicle_automated_driving_function = 7;

ManuelKugelmann · 2019-09-12T09:51:59Z

Vehicle LightState is not properly defined - same as MovingObject_VehicleClassification_LightState ?

Thx for the input!

ThomasNaderBMW · 2019-09-12T11:10:27Z

Vehicle LightState is not properly defined - same as MovingObject_VehicleClassification_LightState ?

@TheDraguun I corrected the mistakes you found. Light_state is wrapped in osi_object, so should be included now. Thx for your comments!
So far it is the same like MovingObject_VehicleClassification_LightState, if this is not enough there are two options we can consider:

Extension of osi_object (LightState) by additional signals we think are missing
Or define an own Light-Message

ManuelKugelmann · 2019-09-13T07:34:23Z

Question: where will the Vehicle message be placed?
As member of SensorView like GroundTruth?
Or into a new root message type?

@TheDraguun I corrected the mistakes you found. Light_state is wrapped in osi_object, so should be included now. Thx for your comments!

The LightState message type in Vehicle and Intentions still needs to be fully named:
optional LightState vehicle_light_state = 8;
should read
optional MovingObject.VehicleClassification.LightState vehicle_light_state = 8;

ThomasNaderBMW · 2019-09-26T08:10:37Z

Question: where will the Vehicle message be placed?
As member of SensorView like GroundTruth?
Or into a new root message type?

@TheDraguun I corrected the mistakes you found. Light_state is wrapped in osi_object, so should be included now. Thx for your comments!

The LightState message type in Vehicle and Intentions still needs to be fully named:
optional LightState vehicle_light_state = 8;
should read
optional MovingObject.VehicleClassification.LightState vehicle_light_state = 8;

You are right, I corrected it.

ThomasNaderBMW · 2019-09-26T08:12:07Z

osi_vehicle.proto should be syntactical correct. I compiled it by using the protoc-compiler. For interested:
https://developers.google.com/protocol-buffers/docs/cpptutorial#why-use-protocol-buffers

Now it is also possible to send commands regarding the target state to one ore more external application(s).

ManuelKugelmann · 2019-10-31T11:56:29Z

Question: where will the Vehicle, Control and Graphics messages be placed?
As member of SensorView like GroundTruth?
Or is it a new root message type?

ManuelKugelmann · 2019-11-06T12:05:53Z

@ThomasNaderBMW Any news on how the new message types will be published?

ManuelKugelmann · 2019-12-03T08:56:24Z

osi_vehicle.proto just contains a link to the real code:
https://raw.githubusercontent.com/OpenSimulationInterface/open-simulation-interface/7a26b8b87e43d0ec854246d1a6587a856111a4f3/osi_vehicle.proto
Wouldn't it be nicer if this branch were a complete OSI3 definition without external links?

ThomasNaderBMW · 2019-12-03T09:24:42Z

osi_vehicle.proto just contains a link to the real code:
https://raw.githubusercontent.com/OpenSimulationInterface/open-simulation-interface/7a26b8b87e43d0ec854246d1a6587a856111a4f3/osi_vehicle.proto
Wouldn't it be nicer if this branch were a complete OSI3 definition without external links?

What do you mean by external links?
The include of osi_occupant?

ManuelKugelmann · 2019-12-03T10:30:16Z

osi_vehicle.proto just contains a link to the real code:
https://raw.githubusercontent.com/OpenSimulationInterface/open-simulation-interface/7a26b8b87e43d0ec854246d1a6587a856111a4f3/osi_vehicle.proto
Wouldn't it be nicer if this branch were a complete OSI3 definition without external links?

What do you mean by external links?
The include of osi_occupant?

The link in osi_vehicle.proto that replaces its content. I took this branch and ran the proto compiler on it - it spit an error for osi-vehicle.proto, I had to follow the link, click a few times to get the code and paste it into the file. All this (imho unneccessary) indirection could be skipped, if the file just contained the code. It also would prevent a (false) merge conflict showing for osi_vehicle.proto.

ThomasNaderBMW · 2019-12-03T16:49:00Z

osi_vehicle.proto just contains a link to the real code:
https://raw.githubusercontent.com/OpenSimulationInterface/open-simulation-interface/7a26b8b87e43d0ec854246d1a6587a856111a4f3/osi_vehicle.proto
Wouldn't it be nicer if this branch were a complete OSI3 definition without external links?

What do you mean by external links?
The include of osi_occupant?

The link in osi_vehicle.proto that replaces its content. I took this branch and ran the proto compiler on it - it spit an error for osi-vehicle.proto, I had to follow the link, click a few times to get the code and paste it into the file. All this (imho unneccessary) indirection could be skipped, if the file just contained the code. It also would prevent a (false) merge conflict showing for osi_vehicle.proto.

Maybe it makes sense to talk directly. Please send me an E-Mail ;)

ManuelKugelmann · 2019-12-04T08:45:08Z

osi_vehicle.proto just contains a link to the real code:
https://raw.githubusercontent.com/OpenSimulationInterface/open-simulation-interface/7a26b8b87e43d0ec854246d1a6587a856111a4f3/osi_vehicle.proto
Wouldn't it be nicer if this branch were a complete OSI3 definition without external links?

What do you mean by external links?
The include of osi_occupant?

The link in osi_vehicle.proto that replaces its content. I took this branch and ran the proto compiler on it - it spit an error for osi-vehicle.proto, I had to follow the link, click a few times to get the code and paste it into the file. All this (imho unneccessary) indirection could be skipped, if the file just contained the code. It also would prevent a (false) merge conflict showing for osi_vehicle.proto.

Maybe it makes sense to talk directly. Please send me an E-Mail ;)

Nevermind - the problem is only subjective and concerns just the meta level, thus it is not worth the time for extended discussion. Resolving the missing code is straight forward and your approach might have benefits to other collaborators that I'm missing.

ManuelKugelmann · 2019-12-04T08:59:41Z

Found a compiler error when trying to build C++ code:
the Notification message has a duplicate definition: It is defined and used in osi_vehicle.proto and in osi_control.proto.

I will do a local quickfix by changing osi_vehicle.proto to import "osi_control.proto"; and deleting the Notification definition.

ThomasNaderBMW · 2019-12-04T12:03:51Z

Found a compiler error when trying to build C++ code:
the Notification message has a duplicate definition: It is defined and used in osi_vehicle.proto and in osi_control.proto.

I will do a local quickfix by changing osi_vehicle.proto to import "osi_control.proto"; and deleting the Notification definition.

Solved the problem by moving all external control messagedefinitions into the control message. Is that working for you?

ManuelKugelmann · 2019-12-04T12:26:28Z

Found a compiler error when trying to build C++ code:
the Notification message has a duplicate definition: It is defined and used in osi_vehicle.proto and in osi_control.proto.
I will do a local quickfix by changing osi_vehicle.proto to import "osi_control.proto"; and deleting the Notification definition.

Solved the problem by moving all external control messagedefinitions into the control message. Is that working for you?

compiles.

Onward to state containers and field setters ...

Corrects a typing error in a description text.

SergejHolzmannBMW

Meeting with Christopher Kiwus & Sergej Holzmann, 20.02.2020

SergejHolzmannBMW · 2019-10-17T13:51:21Z

+//
+message ConfigurationScreen
+{
+    // Some open points:


ADD: id
Please consider the nDisplay configuration:
https://docs.unrealengine.com/en-US/Engine/Rendering/nDisplay/Configuration/index.html

Komm da bitte nochmal auf mich zu.

SergejHolzmannBMW · 2020-02-20T13:28:31Z

+        //
+        // ToDo: Description.
+        //
+        optional double frustum = 8;


Frustum kann kein double sein.

Stattdessen int32?

Update osi_vehicle.proto

67574ff

ThomasNaderBMW added 4 commits September 2, 2019 15:54

Interface to communicate the status of simulation-participants

83d6c80

Update osi_control

3b8c5bf

Update osi_control

7c9c87e

Osi_graphics: First Draft

95e6c41

Feel free to comment!

Corrected the mistakes mentioned by @TheDraguun

848e3cf

Thx for the input!

ThomasNaderBMW changed the title ~~Was fehlt euch noch?~~ What is missing? Sep 12, 2019

ThomasNaderBMW added 2 commits September 17, 2019 19:11

Draft. Under construction..

3b602bc

Corrected LightState to MovingObject.VehicleClassification.LightState

95d3edd

ThomasNaderBMW added 9 commits October 8, 2019 10:44

Update osi_control

52ffe46

Bigger change to osi_control

934db9a

Now it is also possible to send commands regarding the target state to one ore more external application(s).

Rename osi_control to osi_control.proto

e2e633f

Rename osi_graphics to osi_graphics.proto

dfe6b92

Update osi_graphics.proto

08a619f

Update osi_graphics.proto

f83d643

Update osi_vehicle.proto

ee60e94

Update osi_vehicle.proto

fbab41a

Update osi_control.proto

dfa8f6b

Update osi_control.proto

b9fc2a3

ThomasNaderBMW added 10 commits November 25, 2019 14:15

Update osi_graphics.proto

e0dc900

Update osi_graphics.proto

cea8da8

Update osi_graphics.proto

ec241b9

Update osi_graphics.proto

9339063

First draft that could work.

820e5ad

Update osi_vehicle.proto

f28ba98

under construction

a4f1884

Ready to test.

d832d39

Update osi_control.proto

c29646d

Ready to test.

09fb007

Update osi_control.proto

e702a0e

ThomasNaderBMW changed the title ~~What is missing?~~ Development: osi_control and osi_graphics Dec 5, 2019

ThomasNaderBMW and others added 2 commits January 15, 2020 17:23

Corrected some bugs

d89a5d1

OSIGraphics: Correcting typing error

520c436

Corrects a typing error in a description text.

SergejHolzmannBMW reviewed Feb 20, 2020

View reviewed changes

Comment thread osi_graphics.proto

SergejHolzmannBMW reviewed Feb 20, 2020

View reviewed changes

Comment thread osi_graphics.proto Outdated

ThomasNaderBMW added 3 commits April 3, 2020 15:14

Delete osi_vehicle.proto

19c6c9f

Update osi_graphics.proto

02b3773

Update osi_graphics.proto

9cbddac

Repository owner locked as resolved and limited conversation to collaborators Apr 8, 2020

ThomasNaderBMW changed the title ~~Development: osi_control and osi_graphics~~ BackUp: Previous Development Apr 8, 2020

Conversation

ThomasNaderBMW commented Aug 27, 2019

Uh oh!

SergejHolzmannBMW commented Aug 29, 2019

Uh oh!

TKUsaneers commented Sep 10, 2019

Uh oh!

ManuelKugelmann commented Sep 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ManuelKugelmann commented Sep 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ManuelKugelmann commented Sep 12, 2019

Uh oh!

ThomasNaderBMW commented Sep 12, 2019

Uh oh!

ManuelKugelmann commented Sep 13, 2019

Uh oh!

ThomasNaderBMW commented Sep 26, 2019

Uh oh!

ThomasNaderBMW commented Sep 26, 2019

Uh oh!

ManuelKugelmann commented Oct 31, 2019

Uh oh!

ManuelKugelmann commented Nov 6, 2019

Uh oh!

ManuelKugelmann commented Dec 3, 2019

Uh oh!

ThomasNaderBMW commented Dec 3, 2019

Uh oh!

ManuelKugelmann commented Dec 3, 2019

Uh oh!

ThomasNaderBMW commented Dec 3, 2019

Uh oh!

ManuelKugelmann commented Dec 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ManuelKugelmann commented Dec 4, 2019

Uh oh!

ThomasNaderBMW commented Dec 4, 2019

Uh oh!

ManuelKugelmann commented Dec 4, 2019

Uh oh!

SergejHolzmannBMW left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SergejHolzmannBMW Oct 17, 2019

Choose a reason for hiding this comment

Uh oh!

ThomasNaderBMW Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SergejHolzmannBMW Feb 20, 2020

Choose a reason for hiding this comment

Uh oh!

ThomasNaderBMW Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ManuelKugelmann commented Sep 12, 2019 •

edited

Loading

ManuelKugelmann commented Sep 12, 2019 •

edited

Loading

ManuelKugelmann commented Dec 4, 2019 •

edited

Loading