Repository navigation
Valida os schemas da API no modo estrito do Pydantic - #28
Merged
Merged
Conversation
Os modelos deixam de converter tipos por conta própria (um totalprice "150" ou um depositpaid "true" agora reprovam a validação), e checkin/checkout passam a ser date em vez de str. As respostas são validadas direto do JSON com model_validate_json. Campos extras continuam sendo ignorados.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
models/booking.pyherdam deStrictModel(ConfigDict(strict=True)). O Pydantic deixa de converter tipos sozinho: antes, umtotalprice"150"virava150.0e umdepositpaid"true"viravaTrue, e uma mudança de tipo na resposta da API passava sem ser notadacheckinecheckoutpassam destrparadate. Uma data corrompida, como o"0NaN-aN-aN"documentado no TC-018, deixa de valer como texto qualquermodel_validate_json), que confere os tipos exatamente como a API os entrega. A lista deGET /bookingusa o novoBookingIdList(TypeAdapter)model_dump(mode="json"), para que as datas sejam serializadas comoAAAA-MM-DDTest plan
mypy .ruff check .ruff format --check .pytest: 52/52 testes passando, sem reruns (26 cenários BDD contra a API pública e 26 testes unitários), cobertura deapi/emodels/em 100%test_booking_models.py: rejeição detotalpricecomo texto, dedepositpaidcomo texto e de data corrompida; campos extras ignorados; validação da lista de ids