Repository navigation
Remove método morto e adiciona cobertura de código com Codecov - #3
Merged
Merged
Conversation
- Remove exemplo_com_bug de BookingApiClient, que não era usado em lugar nenhum do projeto. - Adiciona pytest-cov medindo api/ e models/ em toda execução de pytest, exportando reports/coverage.xml. - CI envia a cobertura para o Codecov e o README ganha o badge correspondente.
O repositório sempre usou master como branch principal, mas o tests.yml e o README foram escritos referenciando main. Na prática isso significava que o CI nunca disparava em push nem pull request, e a branch master nunca teve proteção de fato configurada no GitHub.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que mudou
exemplo_com_bugdeBookingApiClient, método sem nenhuma chamada no projeto.pytest-cov, medindo cobertura deapi/emodels/em toda execução depytest(relatório no terminal +reports/coverage.xml).tests.ymle o README, que referenciavam a branchmain, quando o repositório sempre usoumaster. Na prática isso significava que o workflow de testes nunca disparava em push nem pull request, e a branchmasternunca teve proteção configurada de fato no GitHub — apesar do README afirmar o contrário.Pendência fora deste PR
A branch
masterainda precisa ser protegida de verdade em Settings → Branches (exigindo o checktestantes do merge), já que nunca esteve configurada.Plano de teste
ruff check .,ruff format --check .emypy .passandopytest -m smokelocal, cobertura gerada emreports/coverage.xml