Repository navigation
Reduz a duplicação nos steps do pytest-bdd - #33
Merged
Merged
Conversation
Os payloads crus partem do booking padrão com sobrescrita de campos, a criação crua com registro do id para limpeza vira um helper, steps com corpo idêntico passam a compartilhar a função, e o Context ganha os atalhos response e token_or_empty. Os arquivos .feature não mudam.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
_booking_payload(), que parte do booking padrão e troca só o campo do cenário (totalprice="nao-e-numero",without="firstname"etc.). Os steps de PUT com payload inválido também passam a usá-la_create_raw()envia o payload e guarda obookingidpara a limpeza. Só registra o id quando a resposta é 200, então também atende o TC-015, que recebe 500 sem JSONContext: ganha as propriedadesresponse, que falha com mensagem clara se nenhuma requisição foi feita, etoken_or_empty. Elas substituem as 25 repetições deassert context.last_response is not Nonee as 11 decontext.token or "".featurenão mudam. O arquivo de steps passa de 408 para 356 linhasOs payloads inválidos agora incluem
additionalneeds, que antes não era enviado nesses casos. É um campo opcional, e os cenários continuam verificando o mesmo comportamento.Test plan
mypy .ruff check .ruff format --check .pytest: 52/52 testes passando contra a API real, incluindo TC-011 e TC-012, que usam os steps unidos