Repository navigation
Cobre o health check, os filtros por data e o Basic auth - #57
Merged
Merged
Conversation
Adiciona os casos TC-026 a TC-034: o GET /ping, os filtros checkin e checkout do GET /booking (com análise de valor-limite) e o Basic auth em PUT, PATCH e DELETE. O BookingApiClient passa a aceitar basic_auth como opção, e o novo HealthApiClient faz o ping. Os três bugs encontrados nos filtros estão documentados nas issues #54, #55 e #56.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Fecha as três lacunas listadas na estratégia de testes, com 9 casos novos (TC-026 a TC-034):
GET /ping)checkincom data anterior à do bookingcheckincom a mesma data do booking$gtem vez de$gte)checkoutcom data posterior à do booking$lt)BookingApiClient: PUT, PATCH e DELETE aceitambasic_auth=(usuário, senha), repassado aoauth=do requests. Sem ele, nada muda. Com Basic auth e sem token, o cookie não é enviadoHealthApiClientcomping(), que vai ser reaproveitado na verificação de saúde antes da suíte (próximo item)common_steps.pyTest plan
mypy .ruff check .ruff format --check .pytest: 79/79 passando contra a API pública (35 cenários BDD e 44 unitários), cobertura deapi/emodels/em 100%, inclusive os desvios de_credentialscodecov/patchpassando