Skip to content

fix: update integration test to use NewClient(Config{}) signature#3

Open
ThorbenD wants to merge 1 commit into
mainfrom
claude/review-pull-requests-60DFx
Open

fix: update integration test to use NewClient(Config{}) signature#3
ThorbenD wants to merge 1 commit into
mainfrom
claude/review-pull-requests-60DFx

Conversation

@ThorbenD
Copy link
Copy Markdown
Owner

Problem

Der Integration-Test-Job auf main schlug mit einem Kompilierungsfehler fehl:

clientlnd.NewClient(host, tlsCert, macaroon) — too many arguments

Ursache

PR #1 hat NewClient von einer 3-Argument-Signatur auf NewClient(cfg Config) umgestellt (als Teil des InvoiceDefaults-Refactorings). Die Datei adapters/lnd/integration_test.go wurde dabei nicht aktualisiert.

Fix

// ALT (kompiliert nicht):
client, err := clientlnd.NewClient(host, tlsCert, macaroon)

// NEU:
client, err := clientlnd.NewClient(clientlnd.Config{
    Host:         host,
    TLSCertPath:  tlsCert,
    MacaroonPath: macaroon,
})

Test plan

  • Unit Tests grün
  • Lint grün
  • Integration Tests kompilieren (skip wenn kein LND vorhanden — kein Fehler)

https://claude.ai/code/session_01BE4mZL4vMG2Qsy1LdBgA6F

NewClient was refactored in PR #1 to accept a Config struct instead of
individual (host, tlsCert, macaroon) arguments. The integration test
was not updated accordingly, causing a compilation failure in the
integration test CI job on main.

https://claude.ai/code/session_01BE4mZL4vMG2Qsy1LdBgA6F
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants