Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 198 additions & 0 deletions pkg/sql/delayed_mysql.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,198 @@
package sql

import (
"encoding/json"
"fmt"
"strings"

"github.com/ThreeDotsLabs/watermill"
"github.com/ThreeDotsLabs/watermill/components/delay"
"github.com/ThreeDotsLabs/watermill/message"
)

type DelayedMySQLPublisherConfig struct {
// DelayPublisherConfig is a configuration for the delay.Publisher.
DelayPublisherConfig delay.PublisherConfig

// OverridePublisherConfig allows overriding the default PublisherConfig.
OverridePublisherConfig func(config *PublisherConfig) error

Logger watermill.LoggerAdapter
}

func (c *DelayedMySQLPublisherConfig) setDefaults() {
if c.Logger == nil {
c.Logger = watermill.NopLogger{}
}
}

// NewDelayedMySQLPublisher creates a new Publisher that stores messages in MySQL with a delay.
// The delay can be set per message with the Watermill's components/delay metadata.
func NewDelayedMySQLPublisher(db ContextExecutor, config DelayedMySQLPublisherConfig) (message.Publisher, error) {
config.setDefaults()

publisherConfig := PublisherConfig{
SchemaAdapter: delayedMySQLSchemaAdapter{
MySQLQueueSchema: MySQLQueueSchema{},
},
AutoInitializeSchema: true,
}

if config.OverridePublisherConfig != nil {
err := config.OverridePublisherConfig(&publisherConfig)
if err != nil {
return nil, err
}
}

var publisher message.Publisher
var err error

publisher, err = NewPublisher(db, publisherConfig, config.Logger)
if err != nil {
return nil, err
}

publisher, err = delay.NewPublisher(publisher, config.DelayPublisherConfig)
if err != nil {
return nil, err
}

return publisher, nil
}

type DelayedMySQLSubscriberConfig struct {
// OverrideSubscriberConfig allows overriding the default SubscriberConfig.
OverrideSubscriberConfig func(config *SubscriberConfig) error

// DeleteOnAck deletes the message from the queue when it's acknowledged.
DeleteOnAck bool

// AllowNoDelay allows receiving messages without the delay metadata.
// By default, such messages will be skipped.
// If set to true, messages without delay metadata will be received immediately.
AllowNoDelay bool

Logger watermill.LoggerAdapter
}

func (c *DelayedMySQLSubscriberConfig) setDefaults() {
if c.Logger == nil {
c.Logger = watermill.NopLogger{}
}
}

// NewDelayedMySQLSubscriber creates a new Subscriber that reads messages from MySQL with a delay.
// The delay can be set per message with the Watermill's components/delay metadata.
func NewDelayedMySQLSubscriber(db Beginner, config DelayedMySQLSubscriberConfig) (message.Subscriber, error) {
config.setDefaults()

where := "delayed_until <= NOW()"

if config.AllowNoDelay {
where += " OR delayed_until IS NULL"
}

schemaAdapter := delayedMySQLSchemaAdapter{
MySQLQueueSchema: MySQLQueueSchema{
GenerateWhereClause: func(params GenerateWhereClauseParams) (string, []any) {
return where, nil
},
},
}

subscriberConfig := SubscriberConfig{
SchemaAdapter: schemaAdapter,
OffsetsAdapter: MySQLQueueOffsetsAdapter{
DeleteOnAck: config.DeleteOnAck,
},
InitializeSchema: true,
}

if config.OverrideSubscriberConfig != nil {
err := config.OverrideSubscriberConfig(&subscriberConfig)
if err != nil {
return nil, err
}
}

sub, err := NewSubscriber(db, subscriberConfig, config.Logger)
if err != nil {
return nil, err
}

return sub, nil
}

type delayedMySQLSchemaAdapter struct {
MySQLQueueSchema
}

func (a delayedMySQLSchemaAdapter) SchemaInitializingQueries(params SchemaInitializingQueriesParams) ([]Query, error) {
createMessagesTable := `
CREATE TABLE IF NOT EXISTS ` + a.MessagesTable(params.Topic) + ` (
` + "`offset`" + ` BIGINT NOT NULL AUTO_INCREMENT PRIMARY KEY,
` + "`uuid`" + ` VARCHAR(36) NOT NULL,
` + "`payload`" + ` ` + a.payloadColumnType(params.Topic) + ` DEFAULT NULL,
` + "`metadata`" + ` JSON DEFAULT NULL,
` + "`acked`" + ` BOOLEAN NOT NULL DEFAULT FALSE,
` + "`created_at`" + ` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
` + "`delayed_until`" + ` TIMESTAMP NULL DEFAULT NULL,
INDEX ` + "`delayed_until_idx`" + ` (` + "`delayed_until`" + `)
);
`

return []Query{{Query: createMessagesTable}}, nil
}

func (a delayedMySQLSchemaAdapter) InsertQuery(params InsertQueryParams) (Query, error) {
insertQuery := fmt.Sprintf(
`INSERT INTO %s (uuid, payload, metadata, delayed_until) VALUES %s`,
a.MessagesTable(params.Topic),
delayedMySQLInsertMarkers(len(params.Msgs)),
)

args, err := delayedMySQLInsertArgs(params.Msgs)
if err != nil {
return Query{}, err
}

return Query{insertQuery, args}, nil
}

func delayedMySQLInsertMarkers(count int) string {
result := strings.Builder{}

for range count {
result.WriteString("(?,?,?,?),")
}

return strings.TrimRight(result.String(), ",")
}

func delayedMySQLInsertArgs(msgs message.Messages) ([]any, error) {
var args []any

for _, msg := range msgs {
metadata, err := json.Marshal(msg.Metadata)
if err != nil {
return nil, fmt.Errorf("could not marshal metadata into JSON for message %s: %w", msg.UUID, err)
}

args = append(args, msg.UUID, msg.Payload, metadata)

// Extract delayed_until from metadata
delayedUntilStr := msg.Metadata.Get(delay.DelayedUntilKey)
if delayedUntilStr == "" {
args = append(args, nil)
} else {
// Convert ISO 8601 to MySQL TIMESTAMP format: "2025-10-22T09:58:00Z" -> "2025-10-22 09:58:00"
delayedUntilStr = strings.Replace(delayedUntilStr, "T", " ", 1)
delayedUntilStr = strings.TrimSuffix(delayedUntilStr, "Z")

args = append(args, delayedUntilStr)
}
}

return args, nil
}
134 changes: 134 additions & 0 deletions pkg/sql/delayed_mysql_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,134 @@
package sql_test

import (
"context"
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/ThreeDotsLabs/watermill"
"github.com/ThreeDotsLabs/watermill-sql/v4/pkg/sql"
"github.com/ThreeDotsLabs/watermill/components/delay"
"github.com/ThreeDotsLabs/watermill/message"
)

func TestDelayedMySQL(t *testing.T) {
t.Parallel()

db := newMySQL(t)

pub, err := sql.NewDelayedMySQLPublisher(db, sql.DelayedMySQLPublisherConfig{
DelayPublisherConfig: delay.PublisherConfig{
DefaultDelayGenerator: func(params delay.DefaultDelayGeneratorParams) (delay.Delay, error) {
return delay.For(time.Second), nil
},
},
Logger: logger,
})
require.NoError(t, err)

sub, err := sql.NewDelayedMySQLSubscriber(db, sql.DelayedMySQLSubscriberConfig{
DeleteOnAck: true,
Logger: logger,
})
require.NoError(t, err)

topic := watermill.NewUUID()

messages, err := sub.Subscribe(context.Background(), topic)
require.NoError(t, err)

msg := message.NewMessage(watermill.NewUUID(), []byte("{}"))

err = pub.Publish(topic, msg)
require.NoError(t, err)

select {
case <-messages:
t.Errorf("message should not be received")
case <-time.After(time.Millisecond * 200):
}

assert.EventuallyWithT(t, func(t *assert.CollectT) {
select {
case received := <-messages:
assert.Equal(t, msg.UUID, received.UUID)
received.Ack()
default:
t.Errorf("message should be received")
}
}, time.Second, time.Millisecond*10)
}

func TestDelayedMySQL_NoDelay(t *testing.T) {
t.Parallel()

db := newMySQL(t)

pub, err := sql.NewDelayedMySQLPublisher(db, sql.DelayedMySQLPublisherConfig{
DelayPublisherConfig: delay.PublisherConfig{
AllowNoDelay: true,
},
Logger: logger,
})
require.NoError(t, err)

t.Run("skip_empty", func(t *testing.T) {
t.Parallel()

sub, err := sql.NewDelayedMySQLSubscriber(db, sql.DelayedMySQLSubscriberConfig{
DeleteOnAck: true,
Logger: logger,
})
require.NoError(t, err)

topic := watermill.NewUUID()

messages, err := sub.Subscribe(context.Background(), topic)
require.NoError(t, err)

msg := message.NewMessage(watermill.NewUUID(), []byte("{}"))

err = pub.Publish(topic, msg)
require.NoError(t, err)

select {
case <-messages:
t.Errorf("message should not be received")
case <-time.After(time.Second * 2):
}
})

t.Run("allow_empty", func(t *testing.T) {
t.Parallel()

sub, err := sql.NewDelayedMySQLSubscriber(db, sql.DelayedMySQLSubscriberConfig{
DeleteOnAck: true,
AllowNoDelay: true,
Logger: logger,
})
require.NoError(t, err)

topic := watermill.NewUUID()

messages, err := sub.Subscribe(context.Background(), topic)
require.NoError(t, err)

msg := message.NewMessage(watermill.NewUUID(), []byte("{}"))

err = pub.Publish(topic, msg)
require.NoError(t, err)

assert.EventuallyWithT(t, func(t *assert.CollectT) {
select {
case received := <-messages:
assert.Equal(t, msg.UUID, received.UUID)
received.Ack()
default:
t.Errorf("message should be received")
}
}, time.Second*2, time.Millisecond*10)
})
}
Loading