fix(example): close HTTP response body and add retry backoff#672
Open
Yanhu007 wants to merge 1 commit intoThreeDotsLabs:masterfrom
Open
fix(example): close HTTP response body and add retry backoff#672Yanhu007 wants to merge 1 commit intoThreeDotsLabs:masterfrom
Yanhu007 wants to merge 1 commit intoThreeDotsLabs:masterfrom
Conversation
The sendCountRequest function in the exactly-once-delivery-counter example has two issues: 1. resp.Body is never closed, leaking file descriptors and TCP connections under load. 2. On error or non-204 status, the function retries immediately in a tight loop with no backoff, potentially overwhelming the server. Close the response body after reading the status code and add a 100ms sleep between retries. Fixes ThreeDotsLabs#664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664
Problem
sendCountRequestin the exactly-once-delivery-counter example:resp.Body— leaks file descriptors and TCP connections under loadFix
resp.Bodyafter reading the status code