exactly-once-counter: drain and close HTTP body, back off on retryable failures#673
Open
SAY-5 wants to merge 1 commit intoThreeDotsLabs:masterfrom
Open
Conversation
…e failures sendCountRequest hits http.Post in a tight loop and never closes the response body, pinning the underlying TCP connection to the example counter until the garbage collector eventually runs. On error or non-204 responses the loop retries immediately, so the unread bodies pile up faster than GC reclaims them and the example run stalls on FD / connection pressure as soon as the server momentarily returns 4xx/5xx (ThreeDotsLabs#664). Drain and close the body on every iteration, and sleep 100ms before retrying both the transport-error path and the non-204 path so we do not hammer the counter handler in a spin loop when the backend is briefly unhealthy. Behaviour on the happy path (204) is unchanged. Fixes ThreeDotsLabs#664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664.
sendCountRequesthitshttp.Postin a tight loop and never closes the response body, pinning the underlying TCP connection to the example counter until the garbage collector eventually runs. On error or non-204 responses the loop retries immediately, so the unread bodies pile up faster than GC reclaims them and the example run stalls on FD / connection pressure as soon as the server momentarily returns 4xx/5xx.This drains and closes the body on every iteration, and sleeps 100ms before retrying both the transport-error path and the non-204 path so we do not hammer the counter handler in a spin loop when the backend is briefly unhealthy. Behaviour on the happy path (204) is unchanged.