Repository navigation
Conversation
…'s 2.4 (PRD-632) The atmosphere sun was 6 x pi "lux" at exposure 1, an effective exposure of pi where Unreal exposes by 2.4 with its meter off: 2^bias x 1.2, from the average SceneView.cpp:2060-2069 pins and key / average (PostProcessEyeAdaptation.cpp:810-821). Three's Lambert and Unreal's shade lux alike, so the sun is now 6, the emissive takes no pi and the sky loses SKY_TO_SUN: its "1.3x too bright, cause not found" fit was this same pi / 2.4 = 1.309. Unreal L1, 12 cells, RTX 2080: 22 -> 61 of 84 rows pass; every region but the floor under the 15 and 4 degree suns passes (Box_White 235/247 against 235/247). A ?exposure=0.764 knob arm on the old code gave the same rows. The kits that pin ACES at a fixed 0.62 (shooter, action-rpg) take 0.62 pi, so their sunlit surfaces stay where the owner chose them. Specs: unreal-look-light red on the old constants (3 fail) -> green.
… slab (PRD-632) A fresh Unreal 5.8.3 project (Substrate, GBuffer format 0) compiles its energy conservation off: the diffuse keeps all the light and the specular takes no multi-scattering weight (ShadingEnergyConservation.ush:7-31). three r187 and the owned engine took 1 - F_Schlick(VoH) from the diffuse, which darkened a floor as the sun neared the horizon. The roughDiffuse (Substrate) path now drops both terms, on three's lighting hook and in the owned engine's standard program. The starter ships shadeLikeSubstrate, the harness calls the template's own in both arms, and below L2 both arms light the sun with no air transmittance (r.SkyAtmosphere 0). Every template AGENTS.md states the filmic default, the 6 lux sun, the fixed 2.4 exposure and the overrides. L1 against Unreal: harness 61/84 -> 70/84, starter 18/84 -> 72/84. The rest is the floor under the 4 degree sun.
…4 floor residual isolated
…auto exposure at high and medium pass
…s the pre-PRD-632 starter look (AC-3 BEFORE arm)
…ecularColor and specularF90; owned web parity serves isolated pages with the threads Wasm rough-diffuse.ts (PRD-632) reads three's Fresnel nodes on three's renderer; the native player bundle refused them (TN_NATIVE_ENGINE_UNBOUND). The owned web lane failed TN_WEB_THREADS_OFF, then the threads .wasm fetch. rough-diffuse parity: web owned Wasm pass, desktop V8 engine player pass (mismatch 0, deltaE 0) against it.
…GAP-4); lutClip: 0 is the named override
…nce) and box 124 after the GAP-4 flip
jonit-dev
added
prd:75%
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
A fresh ThreeNative scene now exposes the frame the way a fresh Unreal 5.8.3 project does (PRD-632).
Why does it matter?
The L1 ladder cells were up to 0.4 EV brighter than Unreal. The cause was an effective exposure of pi, where Unreal uses 2.4 with its meter off. Every template inherits this exposure.
Done
SUN_ILLUMINANCE = SUN_LUX). TheSKY_TO_SUNandEMISSIVE_UNITSfactors are deleted.SceneView.cpp:2060-2069,PostProcessEyeAdaptation.cpp:810-821).Still open