org-page-publisher: change copy in hyperlinks section#1250
Conversation
Coverage Report for CI Build 25484642820Coverage remained the same at 72.329%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
chrisarridge
left a comment
chrisarridge
left a comment
There was a problem hiding this comment.
There is one thing to fix in this and then we're looking good. If you set up elastic search with
python dataload/import_to_elasticsearch.py --clean tests/data/awefw001p00000zgyHZAAY.json --funders tests/data/funders.jsonl --recipients tests/data/recipients.jsonl
and start Grantnav with
PROVENANCE_JSON=tests/data/data.json DEBUG=true python manage.py runserver
then open http://localhost:8000/org/360G-LBFEW#Publisher you'll see the publisher details. Took me a while to sort it!
Then if you can add a screenshot we can get an okay :)
| {% if publisher.datasets.0.distribution.0.accessURL %} | ||
| <li> | ||
| {{ publisher.name }} has provided this link for information about their data | ||
| <a href="{{ publisher.datasets.0.distribution.0.accessURL }}">{{ information about their data }}</a> |
There was a problem hiding this comment.
{{ information about their data }} isn't a working template variable. Changing the line to: {{ publisher.name }} has provided this link for <a href="{{ publisher.datasets.0.distribution.0.accessURL }}">information about their data</a> will fix the issue.
|
@chrisarridge I couldn't run Elasticsearch the way you said. The way I normally run it, it worked. Thanks!
|
…yperlinks section
BibianaC
force-pushed
the
bc/update-copy-publishers
branch
from
969d322 to
6576c03
Compare
mariongalley
left a comment
mariongalley
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
|
@chrisarridge Is it okay to merge with failing links? |
Yes. Let's merge it. It's the same failures on the standard website. #1253 Should resolve this for future PRs. |
3 participants
relates to #843 (comment)