Skip to content

Fix Number fields store as text#1251

Open
BibianaC wants to merge 5 commits into
livefrom
bc/num-fields-store-as-text
Open

Fix Number fields store as text#1251
BibianaC wants to merge 5 commits into
livefrom
bc/num-fields-store-as-text

Conversation

@BibianaC
Copy link
Copy Markdown
Member

Relates to #1225

@BibianaC BibianaC requested a review from chrisarridge May 15, 2026 11:45
@BibianaC
Copy link
Copy Markdown
Member Author

@chrisarridge The links check is failing because of the Standard.

The failing test is the aggregates test. It’s the same issue as the geolocation one. I’ve made some changes in the aggregates file. The test is passing locally for me, but it’s still failing in GitHub.

@chrisarridge
Copy link
Copy Markdown
Contributor

@chrisarridge The links check is failing because of the Standard.

The failing test is the aggregates test. It’s the same issue as the geolocation one. I’ve made some changes in the aggregates file. The test is passing locally for me, but it’s still failing in GitHub.

The aggregates test fails for me locally as well. Interestingly, if I drop both the commits that change aggregates_expected.json then the test passes absolutely fine. Would you expect the aggregates to change for your change in this case? I'm curious about this given that we are also having issues with the geolocation work.

@BibianaC
Copy link
Copy Markdown
Member Author

@chrisarridge the process is:

  • I make changes.
  • Test_api fails.
  • I uncomment the commented code.
  • Run tests.
  • Test Api fails.
  • Comment back the code and change the expected aggregates file.
  • Run tests.
  • Everything is ok.

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26162653211

Coverage remained the same at 72.329%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1984
Covered Lines: 1435
Line Coverage: 72.33%
Coverage Strength: 0.72 hits per line

💛 - Coveralls

@BibianaC
Copy link
Copy Markdown
Member Author

@chrisarridge I have added the file to live. Here, the tests are passing, but locally are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants