This repository was archived by the owner on Dec 10, 2018. It is now read-only.
Open
Conversation
Author
|
Hi guys, |
jparise
approved these changes
Nov 30, 2017
Contributor
jparise
left a comment
jparise
left a comment
There was a problem hiding this comment.
This looks correct to me.
| p[0] = TType.BOOL | ||
| if p[1] == 'byte': | ||
| p[0] = TType.BYTE | ||
| if p[1] == 'i8': |
Contributor
There was a problem hiding this comment.
These conditions should probably become elif so we don't continuously reevaluate p[1] after we find a match.
... but that would be better down in a separate change.
michaelyou
reviewed
Dec 1, 2017
| if p[1] == 'byte': | ||
| p[0] = TType.BYTE | ||
| if p[1] == 'i8': | ||
| p[0] = TType.BYTE |
There was a problem hiding this comment.
It's not good to reuse TType.BYTE, as I8 you defined in p_simple_base_type is useless now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache Thrift has deprecated the
bytetype in favor ofi8in recent versions, this patch makes thriftpy support both.