This repository was archived by the owner on Dec 10, 2018. It is now read-only.
Remove dependency for toro project#301
Open
julioasotodv wants to merge 1 commit intoThriftpy:developfrom
julioasotodv:no_toro
Open
Remove dependency for toro project#301julioasotodv wants to merge 1 commit intoThriftpy:developfrom julioasotodv:no_toro
julioasotodv wants to merge 1 commit intoThriftpy:developfrom
julioasotodv:no_toro
Conversation
Author
|
Build fails in old python configs, just as pretty much all other PRs. But the change passes tests and the Tornado server is able to run correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the Toro project for tornado (https://toro.readthedocs.io/en/stable/) is deprecated (since the project has been merged to mainline Tornado), there is no point on mantaining this dependency (which will be incompatible with Python 3.7).
Tornado itself has the exact same toro.Lock() functionality builtin.