add namespace attributes to __thrift_meta__, then we could access namespace info. #308
Open
truebit wants to merge 1 commit intoThriftpy:masterfrom
Open
add namespace attributes to __thrift_meta__, then we could access namespace info. #308truebit wants to merge 1 commit intoThriftpy:masterfrom
truebit wants to merge 1 commit intoThriftpy:masterfrom
Conversation
cocolato
requested changes
Apr 24, 2025
Comment on lines
+93
to
+109
| thrift = threadlocal.thrift_stack[-1] | ||
| scope = p[2] # language identifier, e.g. 'py', 'java', 'cpp' | ||
| namespace = p[3] # namespace value, e.g. 'tutorial', 'shared' | ||
|
|
||
| # Initialize __thrift_meta__ if not exists | ||
| if not hasattr(thrift, '__thrift_meta__'): | ||
| meta = collections.defaultdict(list) | ||
| setattr(thrift, '__thrift_meta__', meta) | ||
| else: | ||
| meta = getattr(thrift, '__thrift_meta__') | ||
|
|
||
| # Initialize 'namespaces' as dict if not exists | ||
| if 'namespaces' not in meta: | ||
| meta['namespaces'] = {} | ||
|
|
||
| # Store namespace information | ||
| meta['namespaces'][scope] = namespace |
Collaborator
There was a problem hiding this comment.
Suggested change
| thrift = threadlocal.thrift_stack[-1] | |
| scope = p[2] # language identifier, e.g. 'py', 'java', 'cpp' | |
| namespace = p[3] # namespace value, e.g. 'tutorial', 'shared' | |
| # Initialize __thrift_meta__ if not exists | |
| if not hasattr(thrift, '__thrift_meta__'): | |
| meta = collections.defaultdict(list) | |
| setattr(thrift, '__thrift_meta__', meta) | |
| else: | |
| meta = getattr(thrift, '__thrift_meta__') | |
| # Initialize 'namespaces' as dict if not exists | |
| if 'namespaces' not in meta: | |
| meta['namespaces'] = {} | |
| # Store namespace information | |
| meta['namespaces'][scope] = namespace | |
| _add_thrift_meta("namespaces", (p[2], p[3])) |
namespaces metainfo should not be a one - way map. Implementing it in this way would be more reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add namespace attributes to
__thrift_meta__, so we could access namespace info. support #294