Guidelines#6
Open
Sahil8470 wants to merge 14 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
upsurge0
requested changes
Apr 23, 2022
upsurge0
left a comment
upsurge0
left a comment
Contributor
There was a problem hiding this comment.
Nice work 🥳, ignore the prettier check error for now.
You can improve the following:
- Make guidelines a component (/components/Guidelines/Guidelines.tsx), same for the scss file, and call it from pages/guidelines.tsx
- Make the guidelines component an overlay/modal popup, (use a temporary button on /pages/guidelines to open the overlay, it should close after clicking continue)
- Use the CheckBox component.
- Remove the border of continue button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.