fix(poteto-mode): close completed Herdr workers - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
herdr-dispatch --waitreturned a completed worker's output but left its pane open. Each caller had to remember a separate cleanup command, so completed workers could leak panes.The dispatcher now reads the output and closes a verified
doneoridleworker. It leaves unfinished workers open and supports--keep-panewhen a caller needs to inspect a completed worker.Scope
paneClosedto settled dispatch results.working,blocked, andunknownworkers open.0.9.34.Tradeoffs
--waitnow closes completed panes by default. Callers that inspect a completed pane must pass--keep-pane.Blast Radius
The change affects only Herdr dispatches that use
--wait. Background dispatches and unfinished workers keep their current lifecycle.Verification
bun testpassed all 147 dispatcher and vendored-tool tests.bun run typecheckpassed.bun tools/generate.mjspassed and left the tree unchanged.bash -n tests/herdr-e2e.shpassed.paneClosedastrue.herdr pane listconfirmed that its pane was absent.