Conversation
This is a hacky, temporary solution. This state can be achieved by: - Creating a score timeline and then deleting the beat timeline used to create it - Restoring the app state (e.g. after an exception during a timeline command), if the svg viewer happens to be loaded before the beat timeline is restored
"" is a valid value for the color property, it means "use the default color", just as None.
…eline kinds We should leverage classes as first-class citizens to use them instead of relying on an additional TimelineKind abstraction (TimelineKind). This is a first step towards that.
This commits introduces the commands API, a much simpler way to handle user interactions. Commands make all the following obsolete:
- All timeline and timeline component `RequestHandlers`
- `TimelineComponentSelector`
- Several `TimelineSelectors`
- `TiliaActions`
- `user_action` fixture
- `TimelineUi.on_timeline_request`, `TimelineUI.on_timeline_component_request` (substituted by `TimelineUIs.on_timeline_command`)
- `TimelineUIs.pre_process_timeline_request()`
- `tilia\ui\timelines\collection\requests\args.py`
- Several `Post` and `Get` members
- Some `TimelineSelector` members
The core functionality is given by `command.py`, along with fuller documentation.
Usage of commands:
```
# Register a new command
commands.register(
'example.command',
callback_function,
text='Menu Text', # Optional: for display in Qt interface
shortcut='Ctrl+E', # Optional: keyboard shortcut
icon='example_icon' # Optional: icon name in IMG_DIR (without extension)
)
# Execute a command
commands.execute('example.command', arg1, arg2, kwarg1=value1)
```
Examples of commands:
- File commands: 'file.open', 'file.save', 'file.export.img'
- Timeline commands: 'timeline.delete', 'timeline.component.copy'
- View commands: 'view.zoom.in', 'view.zoom.out'
Note that we can pass arguments to commands directly, so we don't need (horrible) things like `TimelineSelector.FROM_MANAGE_TIMELINES_TO_PERMUTE`.
Commands also set the stage for plugins, as they provide a simpler interface to modify application state programatically.
Also add tests for clear commands
Also improve message wording.
|
This shaves of 600 lines, while still adding functionality and fixing a bunch of bugs. Feels good :) |
|
@azfoo, let me know if you want to review this (partly or fully). |
FelipeDefensor
force-pushed
the
refactor-timeline-requests
branch
2 times, most recently
from
7749286 to
4749d00
Compare
…created We should find a more robust solution for this. For instance, we should warn the user that the score won't scroll automatically if the beat timeline is deleted; and we shouldn't rely on dictionaries if we care about order.
FelipeDefensor
force-pushed
the
refactor-timeline-requests
branch
from
78b077a to
b90e4a0
Compare
|
@azfoo, have you run into similar CI failures? Would they be fixed by the new build system? |
|
A locally run Linux pytest fails on the same test. We might have to look into why. |
This crash was particularly annoying when we are working on a new timeline in a separate branch, because the timeline folder wont't get deleted by git when switching branches.
Takeaway: we should use `QTest` to simulate interaction with the ui instead of calling widget methods attributes ourselves.
Takeaway: we should use `QTest` to simulate interaction with the ui instead of calling widget methods attributes ourselves.
|
Just to clarify, why refactor some requests into commands but not the others? |
`on_side_arrow_press` and `on_horizontal_arrow_press` are duplicates, with the latter being defined in the parent tlui. Redefined in audiowave because elements don't have "time" attr.
The main goal here was to get rid of the convoluted logic around |
|
In that case, I am wondering whether it would be easier to document if all of these "external" actions were centralised in one place, like in a JSON file (see: https://github.com/ArjanCodes/examples/tree/main/2026/spec for example). The current naming system of |
2 participants
Introduces the commands API, a much simpler way to handle user interactions. Commands make all the following obsolete:
RequestHandlersTimelineComponentSelectorTimelineSelectorsTiliaActionsuser_actionfixtureTimelineUi.on_timeline_request,TimelineUI.on_timeline_component_request(substituted byTimelineUIs.on_timeline_command)TimelineUIs.pre_process_timeline_request()tilia\ui\timelines\collection\requests\args.pyPostandGetmembersTimelineSelectormembersThe core functionality is given by
command.py, along with fuller documentation.Usage of commands:
Examples of commands:
Note that we can pass arguments to commands directly, so we don't need (horrible) things like
TimelineSelector.FROM_MANAGE_TIMELINES_TO_PERMUTE.Commands also set the stage for plugins, as they provide a simpler interface to modify application state programatically.
This PR also contains small changes that were covenient preliminaries for or complements to the implementation:
- Bug fixes (3be8cee, 24576bd, 6964fdd)
- Additional testing (467cb5e, f07fd4d)
- Convenient refactors (b8d15ef, 914a0bd, 974e715, 769e30b, f13fa08)
- Documentation (45dd1da)