feat: remote preflight, protocol version exposure, retry validation, …#1356
Merged
Timi16 merged 2 commits intoMay 29, 2026
Merged
Conversation
…timestamp helpers Implements four issues across the remote debugging and output subsystems: Timi16#1254 – Remote: add preflight subcommand - `soroban-debug remote <addr> preflight [--output json|pretty]` checks TCP connect, protocol handshake, auth, optional TLS, and an end-to-end ping without loading any contract. - Both pretty and JSON output modes are supported; actionable suggestions are embedded in failure entries. Timi16#1255 – Remote: expose selected protocol version in inspect output - `RemoteClient::selected_protocol_version()` getter added. - Protocol version is now printed in verbose `remote` output and in the `remote inspect` output when `--verbose` is active. - `doctor --remote` now populates `selected_protocol` in its JSON report and prints it in the human-readable section. Timi16#1257 – Remote: validate retry configuration before connecting - `--retry-attempts 0` is now rejected with a clear error and suggestion. - `--retry-max-delay-ms` less than `--retry-base-delay-ms` is rejected with values and a correction hint. - Help text documents the constraints and environment variable interaction. - Man page updated automatically from the arg docstrings. Timi16#1252 – Output: add stable timestamp formatting helpers - `format_timestamp_iso8601(SystemTime) -> String` and `now_iso8601()` added to `src/output.rs` using the existing `chrono` dependency. - Output is always UTC with a `Z` suffix; no locale dependency. - Three unit tests cover the epoch, a known calendar date, and the structural format of the current-time helper.
|
@Anuoluwapo25 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
FIx the conflicts |
Contributor
Author
|
done @Timi16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…timestamp helpers
Implements four issues across the remote debugging and output subsystems:
closes #1254 – Remote: add preflight subcommand
soroban-debug remote <addr> preflight [--output json|pretty]checks TCP connect, protocol handshake, auth, optional TLS, and an end-to-end ping without loading any contract.closes #1255 – Remote: expose selected protocol version in inspect output
RemoteClient::selected_protocol_version()getter added.remoteoutput and in theremote inspectoutput when--verboseis active.doctor --remotenow populatesselected_protocolin its JSON report and prints it in the human-readable section.closes #1257 – Remote: validate retry configuration before connecting
--retry-attempts 0is now rejected with a clear error and suggestion.--retry-max-delay-msless than--retry-base-delay-msis rejected with values and a correction hint.closes #1252 – Output: add stable timestamp formatting helpers
format_timestamp_iso8601(SystemTime) -> Stringandnow_iso8601()added tosrc/output.rsusing the existingchronodependency.Zsuffix; no locale dependency.Description
Related Issue
Type of Change
CI/Test Behavior Changes
What changed in CI or test behavior?
N/A — no CI/test behavior changes
Migration notes
N/A
Checklist
cargo test --workspace --all-features)cargo fmt --all -- --check)cargo clippy --workspace --all-targets --all-features -- -D warnings)make regen-man) and.1files committed