Repository navigation
Friendlier instrument construction errors and compact reprs - #79
Apurv-Salunke wants to merge 1 commit into
Conversation
Raise ConfigurationError with a usage example instead of a raw Pydantic ValidationError when Index/Equity/Future/Option fields are missing, and tighten __repr__ for REPL readability. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 45 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Index,Equity,Future,Option, …) now raiseConfigurationErrorwith a short usage example instead of a raw PydanticValidationError.__repr__forms:Index(NSE:NIFTY),Future(NFO:NIFTY 2026-03-27),Option(NFO:NIFTY 25000 CE 2026-03-27).Test plan
make cilocally (ruff, mypy, 361 tests, coverage ≥64%)tests/unit/test_instrument_models.py— missing fields, invalid type wrap, valid construction, reprsIndex()shows example;Index(exchange=Exchange.NSE, symbol="NIFTY")printsIndex(NSE:NIFTY)Risk notes
pydantic.ValidationErroraround instrument construction will need to catchConfigurationError/TTConnectErrorinstead. Valid construction and resolve-time behaviour are unchanged.Made with Cursor